975292 - [DSDS] "SIM 01" and "SIM 11" names are used in PIN changed successful toast messages instead of "SIM 1" and "SIM 2".

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Enpei]

Attachment: SIM 1.

After changed SIM 1 or SIM 2 PIN code, there will be successful messages but it calls the 2 SIM cards "SIM 01" and "SIM 11".

* Build Number  
Fugu
Gaia      35365feace970bfc51276428f40a477c9c86b7bb
Gecko     048505064d4b8779cd17c820cebb377e0716ef16
BuildID   20140221061554
Version   30.0a1

* Reproduce Steps
1. Enable both SIM cards PIN.
2. Change SIM 1 PIN code. [1]
3. Change SIM 2 PIN code. [2]

* Expected Result
[1] "SIM 1 PIN changed successfully" toast message shows up.
[2] "SIM 2 PIN changed successfully" toast message shows up.

* Actual Result
[1] "SIM 01 PIN changed successfully" toast message shows up.
[2] "SIM 11 PIN changed successfully" toast message shows up.

* Occurrence rate
100%

Comment 1

[Enpei]

Attachment: SIM 2.

Comment 2

[Enpei]

Attachment: time stamp: 14:04, 2/21.

Comment 3

[Ivan Tsay (:ITsay)]

Triage: Plus this bug because this bug affect the DSDS v1.4 work in bug 948584

Comment 4

[Ivan Tsay (:ITsay)]

EJ,

Please help on this 1.4 blocker. Raise you hand if you are overloaded. Thanks!

Comment 5

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

ni me to track this bug.

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch

Arthur, this is a one-line patch. Please give me an r+ xD.

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8381245 [details] [review]
patch

Thanks for the quick response! As we expect cardIndex to be a number everywhere, I think it would be better to make it as a number in the very beginning.

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8381245 [details] [review]
patch

Checked the change, r=me. Please land the patch when travis green, thanks!

Comment 9

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks all,

this patch just got merged onto gaia/master: 5534725dbc8245070cd8c40bd4150cfaef306474

Comment 10

[Enpei]

Verified on Fugu.

Fugu
Gaia      90673159ea569170109678646b01349620b5a941
Gecko     e8b0013422e7cdc7d0d23d3ed99c47bd0fe88d72
BuildID   20140227075828
Version   30.0a1