Closed
Bug 975432
Opened 12 years ago
Closed 12 years ago
sequencer example is pointing to old popcorn.js which is now in bower
Categories
(Webmaker Graveyard :: Popcorn Maker, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: thecount, Assigned: thecount)
Details
Attachments
(1 file)
If you go here: https://popcorn.webmaker.org/templates/assets/plugins/sequencer/popcorn.sequencer.html
You get a bunch of errors. We just need to point it to the new popcorn.js files living in static/bower
Also going to do a quick check that we don't have other references to the old popcorn kicking around.
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → scott
|
|
Assignee | |
Comment 1•12 years ago
|
||
No rush on this.
Turns out it was broken because we require in the analytics module that is not needed nor wanted in the sequencer example, and we were pointing to the wrong files.
I point now to the correct files, and shim the analytics module.
Attachment #8379783 -
Flags: review?(pomax)
Comment on attachment 8379783 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/463
this indeed fixes the problem
Attachment #8379783 -
Flags: review?(pomax) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/fc78e3b4469254b07bd90129613de74c4131e167
Needs verification.
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: needinfo?(scott)
Resolution: --- → FIXED
|
|
Assignee | |
Updated•12 years ago
|
Status: RESOLVED → VERIFIED
Flags: needinfo?(scott)
You need to log in
before you can comment on or make changes to this bug.
Description
•