975486 - [B2G][l12y][Settings]Serbian-Cyrillic: Keyboard title is truncated in 'Selected Keyboards' list.

Status: RESOLVED FIXED

(Mozilla Localizations :: sr / Serbian, defect)

Description

[Ross Kuhlman ([e-mail])]

Attachment: 2014-02-21-09-54-30.png

The user can select multiple keyboards that they can cycle between when typing. The settings menu displays a list of which keyboards can be cycled between. The Serbian-Cyrillic keyboard is truncated on this list.

Repro Steps:
1) Updated Buri to BuildID: 20140220004003
2) Launch Settings app.
3) Navigate to Keyboards > Selected Keyboards > Add more keyboards.
4) Add Serbian-Cyrillic to the list of keyboards.
5) Press back arrow.
6) Observe list of Selected Keyboards.

Actual:
The Serbian-Cyrillic keyboard title is truncated.

Expected:
No truncation is displayed.

Environmental Variables:
Device: Buri v1.3 Moz RIL
BuildID: 20140220004003
Gaia: a73dbe99db9e01f994f09c012e180a5596aa1847
Gecko: 32fd5d798477
Version: 28.0
Firmware Version: v1.2-device.cfg

Notes:

Repro frequency: 100%
See attached: screenshot

Comment 1

[Vanja Tumbas [:civas]]

I checked the gaia files, there are no strings for translating keyboard languages.
Suggestion for fix is just to remove the "(ћирилица)" part.

We can't help you with this one, sorry.

Delphine please cc someone who can help with this bug.

Comment 2

[Delphine Lebédel [:delphine - Use needinfo]]

Flagging UX, as I believe this happens on many other locales as well.
However, would be nice to have QAnalyst to confirm that this is actually on the Serbian screen that this happens. Seems the screenshot is taken from an English screen

Comment 3

[Sarah Parsons]

This issue does reproduce on other languages but only on the ENG builds, so is this something that needs to be corrected?

Comment 4

[Vanja Tumbas [:civas]]

Attachment: 2014-02-27-06-59-02.png

Here is a screenshot for Serbian language.

Comment 5

[Stephany Wilkes]

Flagging Carrie to advise on how to handle keyboard display, and Ivan to see if keyboard files are translated and provide any possible insight on work we may need to do to handle this. Please flag others as appropriate.

Comment 6

[Ivan Tsay (:ITsay)]

Already talked to Carrie about this case and I will update the work we may need to do after Carrie provides the advise.

Comment 7

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

(In reply to Vanja Tumbas [:civas] from comment #1)
> I checked the gaia files, there are no strings for translating keyboard
> languages.
> Suggestion for fix is just to remove the "(ћирилица)" part.
> 
> We can't help you with this one, sorry.
> 
> Delphine please cc someone who can help with this bug.

Vanja,

Please be informed, for current design, we would show the layout name in its native language.
So, I'd like second Vanja's idea on removing "(ћирилица)" part.

Could you please help double confirm this won't affect the semantic of this string?
If so, I would send a pull request to remove this part.

Thanks.

Comment 8

[Vanja Tumbas [:civas]]

(In reply to Rudy Lu [:rudyl] from comment #7)
> 
> Vanja,
> 
> Please be informed, for current design, we would show the layout name in its
> native language.
> So, I'd like second Vanja's idea on removing "(ћирилица)" part.
> 
> Could you please help double confirm this won't affect the semantic of this
> string?
> If so, I would send a pull request to remove this part.
> 
> Thanks.

Hi Rudy.

In Serbia we use Latin and Cyrillic letters. So we are maintaining both versions of fxos gaia.

In image attachment 8382780 [details] look at this 2 strings:
- Tastatura: Српски (ћирилица)
- Tastatura: Srpski

Meaning of translations:
Word "Srpski" is latin version of word "Serbian"
Word "Српски" is cyrillic version of word "Serbian"
Word "(ћирилица)" is cyrillic version of word "Cyrillic"

So removing the "(ћирилица)" part will not affect the semantic of this string. 
There is no need for "(ћирилица)" part to be in that string, it's obviously that keyboard is for cyrillic.

Please send pull request and remove it. 
Thanks!

Comment 9

[Delphine Lebédel [:delphine - Use needinfo]]

NI Vanja.
Has this been fixed? If so please mark as resolved fixed. Then please verify on device and mark as resolved fixed.
Thanks

Comment 10

[Vanja Tumbas [:civas]]

Delphine, this has not been fixed.

Rudy can you please send pull request and remove it. 
Thanks!

Comment 11

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Sure, I'll look into this and send a patch.
Thanks for reminding.

Comment 12

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Patch V1 - pull request 16986

Hi Vanja,

Could you please help review this string change?
Thank you.

Comment 13

[Vanja Tumbas [:civas]]

Comment on attachment 8387495 [details] [review]
Patch V1 - pull request 16986

Everything looks ok.

Comment 14

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Merged to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/5aa42f8269eaeb5cf57e2c4c9dfc2d274763948c

Vanja,

Thanks for the review.