Closed Bug 975735 Opened 6 years ago Closed 6 years ago

Port the LDFLAGS variables in netwerk/streamconv/test/Makefile.in to moz.build

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla30

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

Port the LDFLAGS variables in netwerk/streamconv/test/Makefile.in to moz.build
1.13 KB, patch
mshal
: review+
Details | Diff | Splinter Review 
No description provided.
Assignee: nobody → ehsan
Blocks: xulinmozbuild
Attachment #8380200 - Flags: review?(mshal)
Attachment #8380200 - Flags: review?(mh+mozilla)
Attachment #8380200 - Flags: review?(gps)
Comment on attachment 8380200 [details] [diff] [review]
Port the LDFLAGS variables in netwerk/streamconv/test/Makefile.in to moz.build

>diff --git a/netwerk/streamconv/test/moz.build b/netwerk/streamconv/test/moz.build
>index 2f65f17..e890c71 100644
>--- a/netwerk/streamconv/test/moz.build
>+++ b/netwerk/streamconv/test/moz.build
>@@ -11,8 +11,12 @@ UNIFIED_SOURCES += [
>     'TestStreamConv.cpp',
> ]
> 
> FAIL_ON_WARNINGS = True
> 
> if CONFIG['OS_ARCH'] == 'WINNT':
>     for var in ('MOZ_NO_DEBUG_RTL', 'NGPREFS'):
>         DEFINES[var] = True
>+    if CONFIG['GNU_CC']:

The Makefile had GNU_CXX here. I'm not sure if we would ever have GNU_CXX and not have GNU_CC, but this directory does only have .cpp files.
Attachment #8380200 - Flags: review?(mshal)
Attachment #8380200 - Flags: review?(mh+mozilla)
Attachment #8380200 - Flags: review?(gps)
Attachment #8380200 - Flags: review+
Blocked by bug 973649.
Assignee: ehsan → nobody
Depends on: 973649
https://hg.mozilla.org/mozilla-central/rev/78fd17e89089
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.