Closed Bug 975745 Opened 11 years ago Closed 11 years ago

Remove nsStringKey

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: mccr8, Assigned: anujagarwal464)

References

Details

Attachments

(1 file)

No description provided.
Depends on: 975746
Depends on: 975747
All dependencies filed.
No longer depends on: 975746
For this, you just need to create a new patch on top of your patch from bug 975747, as that's the only thing that uses nsStringKey. For this bug, you just need to delete all of the definitions of nsStringKey from xpcom/ds/nsHashtable.cpp and xpcom/ds/nsHashtable.h
Assignee: nobody → anujagarwal464
Attachment #8391730 - Flags: feedback?(continuation)
Comment on attachment 8391730 [details] [diff] [review] removed nsStringKey defination Review of attachment 8391730 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me! Nathan can review this.
Attachment #8391730 - Flags: review?(nfroyd)
Attachment #8391730 - Flags: feedback?(continuation)
Attachment #8391730 - Flags: feedback+
Attachment #8391730 - Flags: review?(nfroyd) → review+
I'll land this along with bug 975747 once that gets reviewed. try run: https://tbpl.mozilla.org/?tree=Try&rev=90d0ddcfd11b
Thanks for the patch!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: