Closed
Bug 975745
Opened 11 years ago
Closed 11 years ago
Remove nsStringKey
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: mccr8, Assigned: anujagarwal464)
References
Details
Attachments
(1 file)
5.95 KB,
patch
|
froydnj
:
review+
mccr8
:
feedback+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Comment 1•11 years ago
|
||
All dependencies filed.
Reporter | ||
Comment 2•11 years ago
|
||
For this, you just need to create a new patch on top of your patch from bug 975747, as that's the only thing that uses nsStringKey. For this bug, you just need to delete all of the definitions of nsStringKey from xpcom/ds/nsHashtable.cpp and xpcom/ds/nsHashtable.h
Assignee: nobody → anujagarwal464
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #8391730 -
Flags: feedback?(continuation)
Reporter | ||
Comment 4•11 years ago
|
||
Comment on attachment 8391730 [details] [diff] [review]
removed nsStringKey defination
Review of attachment 8391730 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me! Nathan can review this.
Attachment #8391730 -
Flags: review?(nfroyd)
Attachment #8391730 -
Flags: feedback?(continuation)
Attachment #8391730 -
Flags: feedback+
![]() |
||
Updated•11 years ago
|
Attachment #8391730 -
Flags: review?(nfroyd) → review+
Reporter | ||
Comment 5•11 years ago
|
||
I'll land this along with bug 975747 once that gets reviewed.
try run: https://tbpl.mozilla.org/?tree=Try&rev=90d0ddcfd11b
Reporter | ||
Comment 6•11 years ago
|
||
Reporter | ||
Comment 7•11 years ago
|
||
Thanks for the patch!
Comment 8•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•