Closed Bug 975746 Opened 6 years ago Closed 6 years ago

Remove GATHER_ELEMENT_USEAGE_STATISTICS

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: mccr8, Assigned: mccr8)

Details

Attachments

(1 file)

Or just delete it, if it isn't worth keeping around.
Olli, do you think this GATHER_ELEMENT_USEAGE_STATISTICS code is worth keeping around, or should we just delete it?
Flags: needinfo?(bugs)
Ms2ger points out that this dates from bug 107453, written in 2001 by one Johnny Stenback.  Let's just remove it, if nobody has any objections.
Assignee: nobody → continuation
Flags: needinfo?(bugs)
Summary: Convert sGEUS_ElementCounts to a modern hash table → Remove GATHER_ELEMENT_USEAGE_STATISTICS
Actually, smaug pointed that out.
If anybody is interested in keeping this around, I can update the hashtable easily.  The code is super simple, it just doesn't make any sense to leave around if nobody has used it in over a decade.
This code doesn't even compile, probably dating from at least the last time somebody cleaned up headers in this file, so I think that's good evidence this is unused.  I also took the occasion to remove forward declarations that aren't used in the file.  I also removed the comment "XXX todo: add in missing out-of-memory checks" which surely no longer applies in the modern infallible malloc world.

jst wrote this, so he can review its removal. ;)

try run, in case this breaks non-unified builds: https://tbpl.mozilla.org/?tree=Try&rev=f2be548db648
Attachment #8391537 - Flags: review?(jst)
This code doesn't even build, so it doesn't need to block the removal of anything.
No longer blocks: 971264, 975745
Comment on attachment 8391537 [details] [diff] [review]
Remove GATHER_ELEMENT_USEAGE_STATISTICS.

Yes, please. r=jst ;)
Attachment #8391537 - Flags: review?(jst) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/199173f539cd
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.