975769 - "ABORT: out of range" with CSS will-change

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Jesse Ruderman]

Attachment: testcase

With
  user_pref("layout.css.will-change.enabled", true);

###!!! ABORT: out of range: '0 <= aProperty && aProperty < eCSSProperty_COUNT', file layout/style/nsCSSProps.h

Comment 1

[Boris Zbarsky [:bzbarsky]]

This code in nsRuleNode.cpp:

5492         nsCSSProperty prop =
5493           nsCSSProps::LookupProperty(buffer, nsCSSProps::eEnabled);
5494         if (nsCSSProps::PropHasFlags(prop,
5495                                      CSS_PROPERTY_CREATES_STACKING_CONTEXT)) {

needs to check that "prop" didn't come back as eCSSProperty_UNKNOWN before calling PropHasFlags, no?

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

...which I requested in bug 964885 comment 13.

Comment 3

[Benoit Girard (:BenWa)]

As a ride along dholbert points out that we shouldn't use <..., 1> with mWillChange in the style struct.

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: fix

Comment 5

[Benoit Jacob [:bjacob] (mostly away)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/de5bdfd57eb3

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/de5bdfd57eb3