Closed Bug 975773 Opened 6 years ago Closed 6 years ago
_CRASH(this shouldn't be called for filters without inputs) [@ mozilla::gfx::Source Needed Region For Primitive]
Hit MOZ_CRASH(this shouldn't be called for filters without inputs) at gfx/src/FilterSupport.cpp:1415
Crash Signature: [@ mozilla::gfx::SourceNeededRegionForPrimitive] → [@ mozilla::gfx::SourceNeededRegionForPrimitive] [@ mozilla::gfx::FilterSupport::ComputeSourceNeededRegions]
aDescription.Type() is FilterPrimitiveDescription::eNone here, because the specular lighting filter primitive refuses to be created at http://dxr.mozilla.org/mozilla-central/source/content/svg/content/src/nsSVGFilters.cpp?from=nsSVGFilters.cpp:515#517 because it has no frame. In nsSVGFilterInstance::BuildPrimitives(), we don't check the primitive's type and assign the inputs regardless, so the resulting eNone filter has NumberOfInputs() == 1. And there's nothing wrong with that, so we should just not crash in that case.
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Attachment #8380553 - Flags: review?(roc)
Attachment #8380553 - Flags: review?(roc) → review+
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
This was caused by bug 924103 and affects Firefox 28 and 29 as well.
Comment on attachment 8380553 [details] [diff] [review] v1 [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 924103 User impact if declined: crash on specifically-constructed web pages Testing completed (on m-c, etc.): local testing + patch contains crashtest Risk to taking this patch (and alternatives if risky): extremely low String or IDL/UUID changes made by this patch: none
Attachment #8380553 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8380553 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.