Closed Bug 975774 Opened 6 years ago Closed 6 years ago

Clean up imports in Fennec

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 30

People

(Reporter: rnewman, Assigned: rnewman)

Details

Attachments

(26 files)

2.18 KB, patch
Details | Diff | Splinter Review
2.26 KB, patch
Details | Diff | Splinter Review
971 bytes, patch
Details | Diff | Splinter Review
1.34 KB, patch
Details | Diff | Splinter Review
1.41 KB, patch
Details | Diff | Splinter Review
2.12 KB, patch
Details | Diff | Splinter Review
1.67 KB, patch
Details | Diff | Splinter Review
4.44 KB, patch
Details | Diff | Splinter Review
1.66 KB, patch
Details | Diff | Splinter Review
3.67 KB, patch
Details | Diff | Splinter Review
3.66 KB, patch
Details | Diff | Splinter Review
1.81 KB, patch
Details | Diff | Splinter Review
1.52 KB, patch
Details | Diff | Splinter Review
3.27 KB, patch
Details | Diff | Splinter Review
1.92 KB, patch
Details | Diff | Splinter Review
2.66 KB, patch
Details | Diff | Splinter Review
5.81 KB, patch
Details | Diff | Splinter Review
1.95 KB, patch
Details | Diff | Splinter Review
7.62 KB, patch
Details | Diff | Splinter Review
1.97 KB, patch
Details | Diff | Splinter Review
2.23 KB, patch
Details | Diff | Splinter Review
8.60 KB, patch
Details | Diff | Splinter Review
34.44 KB, patch
Details | Diff | Splinter Review
1.64 KB, patch
Details | Diff | Splinter Review
9.80 KB, patch
Details | Diff | Splinter Review
5.99 KB, patch
Details | Diff | Splinter Review
We have a bunch of unused imports, because spotting these without an IDE is hard.

We also don't follow standard Java import orders, and often get the sorting wrong (again, because we do it manually).

Now that we have an IDE, we can fix this and avoid import churn in future patches.
Each of these commits is from a batch of "unused import" warnings in Eclipse. I allowed Eclipse to automatically remove the unused imports and arrange imports according to Java coding conventions.

These shouldn't bitrot most folks, and any bitrotting that does occur should be trivial (imports only, by definition).
I see little reason to land these separately, but now you've done it, let's not squash them.

This appears to not be consistent with https://bugzilla.mozilla.org/show_bug.cgi?id=778472#c8.  Helpfully, Eclipse and IntelliJ order java.* first and last, respectively.  Both are configurable.  Let's put off configuring a future IDE to match the current IDE... into the future.

Bulk rs=me, but at least make sure a local clobber build succeeds.
Local clobber worked.

https://hg.mozilla.org/integration/fx-team/rev/3df95bfeb6a2
https://hg.mozilla.org/integration/fx-team/rev/6f22bfc7f482
https://hg.mozilla.org/integration/fx-team/rev/be3de2cc2194
https://hg.mozilla.org/integration/fx-team/rev/8386e850b5b8
https://hg.mozilla.org/integration/fx-team/rev/5c5bec801501
https://hg.mozilla.org/integration/fx-team/rev/d1b5396f408c
https://hg.mozilla.org/integration/fx-team/rev/8b49d6bf74c5
https://hg.mozilla.org/integration/fx-team/rev/b93273e7d741
https://hg.mozilla.org/integration/fx-team/rev/196d47000206
https://hg.mozilla.org/integration/fx-team/rev/2d3d5db69895
https://hg.mozilla.org/integration/fx-team/rev/247a1e2ae3da
https://hg.mozilla.org/integration/fx-team/rev/db5561e4128d
https://hg.mozilla.org/integration/fx-team/rev/007ad010e34b
https://hg.mozilla.org/integration/fx-team/rev/b61a8688f495
https://hg.mozilla.org/integration/fx-team/rev/c04c7f8a8400
https://hg.mozilla.org/integration/fx-team/rev/b6ad2d8d35e2
https://hg.mozilla.org/integration/fx-team/rev/40506024447f
https://hg.mozilla.org/integration/fx-team/rev/dcc5b139e033
https://hg.mozilla.org/integration/fx-team/rev/3808b0f73cb5
https://hg.mozilla.org/integration/fx-team/rev/5e81714bb933
https://hg.mozilla.org/integration/fx-team/rev/3439c9360b42
https://hg.mozilla.org/integration/fx-team/rev/fec804590cf9
https://hg.mozilla.org/integration/fx-team/rev/68f3b7ceb34f
https://hg.mozilla.org/integration/fx-team/rev/37b322ef8c2e
https://hg.mozilla.org/integration/fx-team/rev/6275976db4d1
https://hg.mozilla.org/integration/fx-team/rev/d7f05ca315a6
Target Milestone: --- → Firefox 30
https://hg.mozilla.org/mozilla-central/rev/3df95bfeb6a2
https://hg.mozilla.org/mozilla-central/rev/6f22bfc7f482
https://hg.mozilla.org/mozilla-central/rev/be3de2cc2194
https://hg.mozilla.org/mozilla-central/rev/8386e850b5b8
https://hg.mozilla.org/mozilla-central/rev/5c5bec801501
https://hg.mozilla.org/mozilla-central/rev/d1b5396f408c
https://hg.mozilla.org/mozilla-central/rev/8b49d6bf74c5
https://hg.mozilla.org/mozilla-central/rev/b93273e7d741
https://hg.mozilla.org/mozilla-central/rev/196d47000206
https://hg.mozilla.org/mozilla-central/rev/2d3d5db69895
https://hg.mozilla.org/mozilla-central/rev/247a1e2ae3da
https://hg.mozilla.org/mozilla-central/rev/db5561e4128d
https://hg.mozilla.org/mozilla-central/rev/007ad010e34b
https://hg.mozilla.org/mozilla-central/rev/b61a8688f495
https://hg.mozilla.org/mozilla-central/rev/c04c7f8a8400
https://hg.mozilla.org/mozilla-central/rev/b6ad2d8d35e2
https://hg.mozilla.org/mozilla-central/rev/40506024447f
https://hg.mozilla.org/mozilla-central/rev/dcc5b139e033
https://hg.mozilla.org/mozilla-central/rev/3808b0f73cb5
https://hg.mozilla.org/mozilla-central/rev/5e81714bb933
https://hg.mozilla.org/mozilla-central/rev/3439c9360b42
https://hg.mozilla.org/mozilla-central/rev/fec804590cf9
https://hg.mozilla.org/mozilla-central/rev/68f3b7ceb34f
https://hg.mozilla.org/mozilla-central/rev/37b322ef8c2e
https://hg.mozilla.org/mozilla-central/rev/6275976db4d1
https://hg.mozilla.org/mozilla-central/rev/d7f05ca315a6
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Depends on: 976671
You need to log in before you can comment on or make changes to this bug.