975796 - [ja] Replace Yahoo icon with hi-dpi version

Status: RESOLVED FIXED

(Mozilla Localizations :: ja / Japanese, defect)

Description

[Francesco Lodolo [:flod]]

Japanese is still using the old red icon, but we should update it to hidpi for desktop and have a 74px version of Metro.

Comment 1

[Masahiko Imanaka [:marsf]]

Yahoo! Japan is still using red Y! icon.
http://www.yahoo.co.jp/

The new one must be same with this that you mentioned at bug 967388#c12.

Comment 2

[Francesco Lodolo [:flod]]

Mike, are you the right person to fetch these icons? Not sure about Metro at this point, but I guess we should still update desktop for consistency.

Comment 3

[Francesco Lodolo [:flod]]

Actually, I realized http://www.yahoo.co.jp/favicon.ico includes 4 sizes (16, 24, 32, 48) so I can create a patch for that for Desktop (16px and 32px).

Comment 4

[Francesco Lodolo [:flod]]

Attachment: bug975796.patch

Replace current icon with 16px+32px .ico 

Same patch will be applied also to ja-JP-mac

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 8392079 [details] [diff] [review]
bug975796.patch

Did you test this?  Firefox choked on application/ico, but worked on image/x-icon (which is what we use everywhere else) when I tested the data: URL directly.  r=me with that fixed.

Comment 6

[Francesco Lodolo [:flod]]

(In reply to Mike Connor [:mconnor] from comment #5)
> Did you test this? 

Yes. Installed locally the resulting searchplugin and it worked displaying the icon, but I don't have a Retina display to verify if the icon is actually different.

Thanks for the review. I'll wait for merge day to end before landing this.

Comment 7

[Francesco Lodolo [:flod]]

Landed on Aurora and Central
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja/rev/81032a3aacc3
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja-JP-mac/rev/6f2f5b197018
http://hg.mozilla.org/l10n-central/ja/rev/4a4a60f00204
http://hg.mozilla.org/l10n-central/ja-JP-mac/rev/e799ed2dd3df

@hATrayflood
Can someone from your team check that everything looks good in the next Aurora builds and mark this bug as verified?