975802 - [Camera] Separate front/back picture/video size settings

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Wilson Page [:wilsonpage]]

Front and back cameras are different physical hardware. They both have differing available pictureSizes and recorderProfiles, therefore they should be persisted and configured seperately.

Comment 1

[Wilson Page [:wilsonpage]]

Attachment: pull-request (camera-new-features)

Comment 2

[David Flanagan [:djf]]

I've run out of time to finish this review today. Comments are on github, but no red flags.  All that I have left to review is the final settings tests that were disabled by a previous patch.

I'm thinking that you should roll these three patches into a single one and let's land them together in a single commit.

Comment 3

[David Flanagan [:djf]]

Comment on attachment 8385281 [details] [review]
pull-request (camera-new-features)

I think there is a bug in controllers/activity.js, and I your tests for the setting alias class need to test the method forwarding stuff. I don't like the fireArgs hack to link evt.js and setting-alias.js, and would like it if you can do that another way.  Other minor comments on gihtub.

Overall, I'm concerned that the settings library has become so complicated, but don't feel like there is time to work to simplify it.

So r+, if you fix the things listed above.

As I've said before I think it would be easiest if you just combined all three commits in the pull request into one. Once you're able to address the review comments on those other patches I'll review again and we can get this all landed!

Comment 4

[Justin D'Arcangelo [:justindarc]]

Attachment: UNIFIED PATCH: pull-request (camera-new-features)

Comment 5

[David Flanagan [:djf]]

Comment on attachment 8386482 [details] [review]
UNIFIED PATCH: pull-request (camera-new-features)

Landed in 980599. Clearing review request and marking resolved.