Closed Bug 975817 Opened 6 years ago Closed 6 years ago

Profile manager: XML parsing error due to missing entities

Categories

(SeaMonkey :: Startup & Profiles, defect, critical)

x86_64
All
defect
Not set
critical

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.27

People

(Reporter: stefanh, Assigned: stefanh)

References

Details

Attachments

(1 file, 1 obsolete file)

The patch in bug 973371 re-named 2 entities in the toolkit/mozapps profileSelection.xul file.

We could either use the new entities or use the old one. I'm a bit in-between here, since I think the new string is a bit long (it doesn't look that nice in the dialog). The old string fits nicer with the ui, so I think I vote for keeping it. It's no big deal, though - we can use the new one if we want.

I'll put up patches in a few minutes.
Attachment #8380343 - Flags: review?(neil)
Status: NEW → ASSIGNED
Comment on attachment 8380343 [details] [diff] [review]
Version 1, keep old string

>+	<key>NSDisablePersistence</key>
>+	<true/>
Part of another patch?

>+<!ENTITY            autoSelect.label         "Don't ask at startup">
I didn't like the new one either. How about "Default to this profile"?
Attachment #8380343 - Flags: review?(neil) → review+
This the the alternative version.
Attachment #8380344 - Flags: review?(neil)
Attachment #8380344 - Flags: review?(neil) → review-
(In reply to neil@parkwaycc.co.uk from comment #2)
> Comment on attachment 8380343 [details] [diff] [review]
> Version 1, keep old string
> 
> >+	<key>NSDisablePersistence</key>
> >+	<true/>
> Part of another patch?

Whoops, yes - sorry.

> >+<!ENTITY            autoSelect.label         "Don't ask at startup">
> I didn't like the new one either. How about "Default to this profile"?

Hmm, that could work - but (maybe it's just me) doesn't the information that the dialog doesn't show up gets lost?
Pushed with Neil's suggestion: http://hg.mozilla.org/comm-central/rev/51589d434f0e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.27
Attachment #8380344 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.