975817 - Profile manager: XML parsing error due to missing entities

Status: RESOLVED FIXED

(SeaMonkey :: Startup & Profiles, defect)

Description

[Stefan [:stefanh]]

The patch in bug 973371 re-named 2 entities in the toolkit/mozapps profileSelection.xul file.

We could either use the new entities or use the old one. I'm a bit in-between here, since I think the new string is a bit long (it doesn't look that nice in the dialog). The old string fits nicer with the ui, so I think I vote for keeping it. It's no big deal, though - we can use the new one if we want.

I'll put up patches in a few minutes.

Comment 1

[Stefan [:stefanh]]

Attachment: Version 1, keep old string

Comment 2

[[e-mail]]

Comment on attachment 8380343 [details] [diff] [review]
Version 1, keep old string

>+	<key>NSDisablePersistence</key>
>+	<true/>
Part of another patch?

>+<!ENTITY            autoSelect.label         "Don't ask at startup">
I didn't like the new one either. How about "Default to this profile"?

Comment 3

[Stefan [:stefanh]]

Attachment: Alternative version, use the new string

This the the alternative version.

Comment 4

[Stefan [:stefanh]]

(In reply to [e-mail] from comment #2)
> Comment on attachment 8380343 [details] [diff] [review]
> Version 1, keep old string
> 
> >+	<key>NSDisablePersistence</key>
> >+	<true/>
> Part of another patch?

Whoops, yes - sorry.

> >+<!ENTITY            autoSelect.label         "Don't ask at startup">
> I didn't like the new one either. How about "Default to this profile"?

Hmm, that could work - but (maybe it's just me) doesn't the information that the dialog doesn't show up gets lost?

Comment 5

[Stefan [:stefanh]]

Pushed with Neil's suggestion: http://hg.mozilla.org/comm-central/rev/51589d434f0e