975850 - cannot enter card view from homescreen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

STR:

1) Launch an app.
2) Return to homescreen.
3) Long-press the home button to bring up card view.

Expected Results:

Card view should be displayed.

Actual Results:

Nothing happens.  You remain on homescreen.

If you are in an app and long-press the home button then the card view is displayed.

This was on recent v1.4:

  gecko hg: 31113754db3b
  gaia git: 15b998c0a57e9415fd694fca2477ff1ee8e81661

Comment 1

[Zac C (:zac)]

Possibly: https://github.com/mozilla-b2g/gaia/pull/15914

Comment 2

[Jason Smith [:jsmith]]

(In reply to Zac C (:zac) from comment #1)
> Possibly: https://github.com/mozilla-b2g/gaia/pull/15914

Aus? If that's true, then we need to backout that patch.

Comment 3

[Aus Lacroix [:aus]]

It's possible that it's related, lots of stuff landed on Thursday and Friday though. It's potentially an interaction between those landings and mine that's causing this but it's exhibited via the cards view. We'll see. Either way it's priority one. If I can't see clearly what's happening within 1 hour I will backout on master.

Comment 4

[Aus Lacroix [:aus]]

Attachment: Pull Request - Add more tests, adjust default position in stack manager

* Stack Manager should start up with _current set to -1 since we launch the homescreen by default.
* Cards View should show most recently used application (last on stack) when the homescreen is being shown.
* Added tests for showing cards view from homescreen in default running state (eg. no recent apps)
* Added tests for stack manager to ensure that position is always -1 initially.
* Seperated the tests for cards view active, one set for in the rocketbar, one set for outside of the rocketbar.
** The original test covered the default running state case, it was updated for the task manager being shown in
   rocketbar but we did _not_ backout that change when disabling the rocketbar in 1.4.

r=?

Comment 5

[Aus Lacroix [:aus]]

Ben, does this fix the issue for you as well?

Comment 6

[Aus Lacroix [:aus]]

FYI, I'm hoping to get a review from Alive this evening prior to the builds being started. If not. I will back out the change.

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8380834 [details] [review]
Pull Request - Add more tests, adjust default position in stack manager

Please squash and make sure test passes.

BTW don't worry to be backout we have bubble-tea branch.

Comment 8

[Aus Lacroix [:aus]]

Commit: https://github.com/mozilla-b2g/gaia/commit/4d8f67e285871a990ea5fbb6544e8df55d29b613

Fixed!

Comment 9

[John Hammink]

I can confirm this fix on today's 1.4 on buri:
Gaia      80d6405725788327102cab36e8d8c017cf25fb23
Gecko     https://hg.mozilla.org/mozilla-central/rev/626d99c084cb
BuildID   20140226040201
Version   30.0a1
ro.build.version.incremental=324
ro.build.date=Thu Dec 19 14:04:55 CST 2013