Closed
Bug 975896
Opened 10 years ago
Closed 10 years ago
Bugzilla crashes when editing a flag type which is not specifically requestable
Categories
(Bugzilla :: Attachments & Requests, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 5.0
People
(Reporter: LpSolit, Assigned: LpSolit)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
4.06 KB,
patch
|
glob
:
review+
|
Details | Diff | Splinter Review |
This is a regression due to bug 956233. It doesn't make sure that there are flags to update. Also, the SQL query incorrectly looks at type_id instead of id, clearing the wrong flags.
|
Assignee | |
Comment 1•10 years ago
|
||
This patch also fixes all places where $dbh->selectrow_array() was incorrectly used instead of $dbh->selectcol_arrayref(). The former only returns the first row, which is not what we want.
Attachment #8380409 -
Flags: review?(glob)
|
|
Assignee | |
Updated•10 years ago
|
Summary: Bugzilla crashes when editing a flag type with is not specifically requestable → Bugzilla crashes when editing a flag type which is not specifically requestable
Comment on attachment 8380409 [details] [diff] [review] patch, v1 r=glob
Attachment #8380409 -
Flags: review?(glob) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/ modified Bugzilla/Attachment.pm modified Bugzilla/Classification.pm modified Bugzilla/FlagType.pm Committed revision 8925.
|
|
Assignee | |
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•