975921 - [Sora][APK][3rd][Marketplace] If you download fail in Marketplace, you cannot download again in the same place

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Description

[sync-1]

Mozilla build ID: 20140208004002
 
 DEFECT DESCRIPTION:
 if you download fail in Marketpalce,you can not download again in the same place in marketplace,i can not open marketplace in  Beetle lite FF  
 REPRODUCING PROCEDURES:
 1.lanuch Marketplace to choose an app to  click "free"
 2.Pull-down status bar, cancel the download before downloading sucessfully
 3.go back to  the interface which have the app you download before
 4.look at the interface,then you will find "free" change to "lanuch", but clicking "lanuch" can not lanuch the app-->KO
 EXPECTED BEHAVIOUR:
 i think the "lanuch" is not Suitable,if you download fail ,you should can download again in this place 
 ASSOCIATE SPECIFICATION:
 TEST PLAN REFERENCE:
 TOOLS AND PLATFORMS USED:
 USER IMPACT:
 
 REPRODUCING RATE:
 100%

Comment 1

[Jason Smith [:jsmith]]

This is probably because marketplace isn't listening to the right event to determine when to show launch - they should listen to ondownloadsuccess, not the onsuccess callback of the install function.

Comment 2

[Lingling Zhao]

So please help to contact marketplace developer to solve this problem.

Thanks.

Comment 3

[krupa raj[:krupa]]

cvan is probably the best bet here.

Comment 4

[Lingling Zhao]

I can still reproduce the issue now.
Has it been known by the Marketplace developer?

Comment 5

[Christopher Van Wiemeersch [:cvan]]

You're right: https://github.com/mozilla/fireplace/blob/master/hearth/media/js/apps.js#L63

Comment 6

[Lingling Zhao]

I think the user could be able to continue to download the app.
So when can I get the right result?

Comment 7

[Jason Smith [:jsmith]]

Server side issue, not blocking.

Comment 8

[Lingling Zhao]

Hi vcan,

What about this problem now?

Comment 9

[Lingling Zhao]

Any one works on it?

Comment 10

[Jack Liu]

Dear Mozilla colleagues,

Although this is server side issue, but it's blocker of IOT.

Please put it at high priority.

Thanks.

Comment 11

[Christopher Van Wiemeersch [:cvan]]

This is just a matter of changing a few lines in `apps.js`.

Comment 12

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

(In reply to Christopher Van Wiemeersch [:cvan] from comment #11)
> This is just a matter of changing a few lines in `apps.js`.

Glad to know that Chris, so will you help to do the modification?

Thanks

Vance

Comment 13

[Lingling Zhao]

Hi all,

The issue still can be reproduced.

Comment 14

[Christopher Van Wiemeersch [:cvan]]

This will get fixed in the next week. Thank you for your patience.

Comment 15

[Christopher Van Wiemeersch [:cvan]]

This is most definitely not a P1 too.

Comment 16

[Lingling Zhao]

It's really a serious issue for users.
Please let me know if it's ok in the next week.

Thanks.

Comment 17

[Christopher Van Wiemeersch [:cvan]]

David, could you please assign this issue to a developer? (See comment 5.)

Comment 18

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

Per Sora project, I agree this is not a P1 issue as long as it is fixed before the product is launched. However, for the FFOS phones that already on the market, this might still be an annoying issue. So really appreciate your help to fix it next week

Vance

Comment 19

[David Durst [:ddurst]]

(In reply to Christopher Van Wiemeersch [:cvan] from comment #17)
> David, could you please assign this issue to a developer? (See comment 5.)

On it.

Comment 20

[krupa raj[:krupa]]

Okay, this broke packaged app installs in all kinda weird ways.

STR:
1. Search for :packaged in Marketplace-dev
2. Click the 'Free' button to install one of the app
3. Confirm Install
4. While the Download is still happening, stop the download from the Notifications screen
5. Try installing a different app

After step #4, button status still changes to 'Launch' when it shouldn't
After step #5, button status reverts to 'Free' and app is not installed.

Comment 21

[Lingling Zhao]

I get a new version "20140331214114", but this issue still can be reproduced.

Comment 22

[Christopher Van Wiemeersch [:cvan]]

(In reply to Lingling Zhao from comment #21)
> I get a new version "20140331214114", but this issue still can be reproduced.

This did not get pushed to production yet. And please patiently wait until this bug is closed.

Davor, what's the status of this?

Comment 23

[Davor Spasovski [:spasovski]]

https://github.com/mozilla/fireplace/pull/430 exists and awaits review. I hear you'll be on PTO for a bit so I'll have mat and ngoke take a look unless you still have time.

Comment 24

[Lingling Zhao]

This issue still can be reproduced.

Comment 25

[Lingling Zhao]

Hi Christ,

This issue still happens, can you help to check it?

Thanks.

Comment 26

[Kevin Ngo [:ngoke]]

I can tackle this as a part of https://bugzilla.mozilla.org/show_bug.cgi?id=1002779

Comment 27

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

Hi Keven, any update on this one?

Thanks

Comment 28

[Kevin Ngo [:ngoke]]

I believe when an install fails, it still shows up in a partially installed state on the homescreen. Attempting to retrigger the install would give an error about it already being installed.

Comment 29

[Kevin Ngo [:ngoke]]

Given FirefoxOS does this weird thing if an install fails, it'll still be registered as installed, but in a pending state that we can't detect or re-trigger, this might not be feasible without help from platform.

Comment 31

[Kevin Ngo [:ngoke]]

Going to need to bump this to Gaia or Platform to make appropriate changes to API to fix.

Comment 32

[Kevin Ngo [:ngoke]]

I don't think this can realistically be solved. It needs support from platform to be able to re-trigger a failed download. But the platform won't allow it. Even if it's solved, it won't be backported to older FxOS versions. :(