Closed
Bug 975975
Opened 10 years ago
Closed 10 years ago
Remove apparently obsolete Metro TextSelection code
Categories
(Firefox for Metro Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 30
People
(Reporter: capella, Assigned: capella)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
2.65 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
Found what looks like original, unused code from Metro: http://mxr.mozilla.org/mozilla-central/search?string=%22Browser%3ATapOnSelection%22&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central Originator of the "Browser:TapOnSelection" message can't be located, and the SelectionHelperUI.canHandle() method it seems to invoke is not defined.
Attachment #8380522 -
Flags: review?(jmathies)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8380522 [details] [diff] [review] cleanupMetro.diff Yep, looks dead.
Attachment #8380522 -
Flags: review?(jmathies) → review+
|
Assignee | |
Comment 2•10 years ago
|
||
TRY: https://tbpl.mozilla.org/?tree=Try&rev=659ee1d2f780
|
|
Assignee | |
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/a11044dfe7cd
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a11044dfe7cd
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
|
||
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•