Closed Bug 975981 Opened 6 years ago Closed 6 years ago

Unable to import bookmarks from IE when they contain a .url which has no URL field

Categories

(Firefox :: Migration, defect)

27 Branch
x86
Windows 7
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 30

People

(Reporter: ryou, Assigned: ryou)

References

Details

(Whiteboard: [qa!])

Attachments

(1 file)

As mentioned in Bug 895025, some .url shortcuts throw too.

I took a look and found out that these .url shortcuts that throw have no URL field under [InternetShortcut] section. Attached is an example .url shortcut.

I think we can skip these .url shortcuts as we can't get url attribute from them, and the landed patch in Bug 895025 has solved this by only reporting error without stopping the import.
(In reply to Rui You [:ryou] from comment #0)
> I think we can skip these .url shortcuts as we can't get url attribute from
> them, and the landed patch in Bug 895025 has solved this by only reporting
> error without stopping the import.

is there any downside to the current implementation that just reports a problem and skips the entry?
(In reply to Marco Bonardo [:mak] from comment #1)
> (In reply to Rui You [:ryou] from comment #0)
> > I think we can skip these .url shortcuts as we can't get url attribute from
> > them, and the landed patch in Bug 895025 has solved this by only reporting
> > error without stopping the import.
> 
> is there any downside to the current implementation that just reports a
> problem and skips the entry?

I think it's OK. These .url files seem useless for the lack of URL attribute. We can't import a bookmark without knowing its URL. I guess all we can do is skipping and reporting.
so I guess this is basically to be marked as fixed by Bug 895025?
(In reply to Marco Bonardo [:mak] from comment #3)
> so I guess this is basically to be marked as fixed by Bug 895025?

Yup. I guess so.
ok, cool.
Assignee: nobody → ryou
Status: NEW → RESOLVED
Closed: 6 years ago
Depends on: 895025
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
Keywords: verifyme
Whiteboard: [qa+]
This issue is verified fixed based on attachment 8380533 [details] and Comment 4, using Windows 7 64-bit [1] with:
- the latest Beta (Build ID: 20140318013849),
- the latest Aurora (Build ID: 20140324004000).

Additional information:
The message displayed in the case of the skipped .url file that is missing its url field is:
> Unable to import IE favorite (URL file without URL field.url): [Exception... "Component returned 
> failure code:
> 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIFileProtocolHandler.readURLFile]"  nsresult: "0x80040111 
> (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: resource://app/components/IEProfileMigrator.js :: 
> B__migrateFolder :: line 262"  data: no]


1. Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0
Status: RESOLVED → VERIFIED
Keywords: verifyme
Whiteboard: [qa+] → [qa!]
You need to log in before you can comment on or make changes to this bug.