975997 - |APP=homescreen make| doesn't work

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

|APP=homescreen make| doesn't work because build_stage/webapps-mapping.json doesn't give enough information to build script of homescreen app.

error message:
> $ APP=homescreen make
> XULrunner directory: xulrunner-sdk-26/xulrunner-sdk
> run-js-command  svoperapps
> [svoperapps.js] PROFILE_DIR, GAIA_DISTRIBUTION_DIR, VARIANT_PATH are all required
> run-js-command  webapp-manifests
> Building homescreen app to build_stage...
> Invalid JSON file : /Users/yurenju/Documents/workspace/gaia/apps/homescreen/everything.me/config/local.json
> Exception: Error: Can not find application communications at apps
> HomescreenAppBuilder.prototype.getIconDiscriptorFromApp@resource://gre/modules/commonjs/toolkit/loader.js -> file:////Users/yurenju/Documents/workspace/gaia/apps/homescreen/build/build.js:119
> map_homescreens@resource://gre/modules/commonjs/toolkit/loader.js -> file:////Users/yurenju/Documents/workspace/gaia/apps/homescreen/build/build.js:283
> HomescreenAppBuilder.prototype.customizeHomescreen@resource://gre/modules/commonjs/toolkit/loader.js -> file:////Users/yurenju/Documents/workspace/gaia/apps/homescreen/build/build.js:288
> HomescreenAppBuilder.prototype.execute@resource://gre/modules/commonjs/toolkit/loader.js -> file:////Users/yurenju/Documents/workspace/gaia/apps/homescreen/build/build.js:301
> exports.execute@resource://gre/modules/commonjs/toolkit/loader.js -> file:////Users/yurenju/Documents/workspace/gaia/apps/homescreen/build/build.js:311
> @-e:1

Comment 1

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: github PR: https://github.com/mozilla-b2g/gaia/pull/16561

Comment 2

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8380563 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/16561

redirect review to George

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8380563 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/16561

I tested the patch on bubble-tea branch and found out we can't execute |APP=ANYAPP make| anymore. It's because keyboard-layout.js (bug 913782) still need webapps-mapping.json to gen layout config. 

I suggest we should still keep original make rule.

Comment 4

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8380563 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/16561

Thanks for your review! pull request is updated.

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8380563 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/16561

Yah, I don't see any necessary for this line |webapp.sourceDirectoryName != config.BUILD_APP_NAME|.

r=gduan.

Comment 6

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

merged, thank you!

https://github.com/mozilla-b2g/gaia/commit/66cf24e62444ad4efa2690f461e2273e785ec4f7

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

travis: https://travis-ci.org/mozilla-b2g/gaia/builds/20112894