Closed
Bug 976033
Opened 10 years ago
Closed 10 years ago
The bookmark icon under the bookmark submenu is grayed out
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox27 unaffected, firefox28 unaffected, firefox29 unaffected, firefox30 fixed, fennec30+)
RESOLVED
FIXED
Firefox 30
Tracking | Status | |
---|---|---|
firefox27 | --- | unaffected |
firefox28 | --- | unaffected |
firefox29 | --- | unaffected |
firefox30 | --- | fixed |
fennec | 30+ | --- |
People
(Reporter: cos_flaviu, Assigned: bnicholson)
References
Details
Attachments
(2 files)
63.98 KB,
image/png
|
Details | |
1.23 KB,
patch
|
wesj
:
review+
|
Details | Diff | Splinter Review |
Environment: Device: Asus Transformer Tab (Android 4.0.3); Build: Nightly 30.0a1 (2014-02-23); Steps to reproduce: 1. Load a page (e.g. google.com); 2. Tap on the bookmark star to open the bookmark submenu; 3. Tap on the bookmark button. Expected result: The page is successfully bookmarked and the bookmark icon is correctly displayed. Actual result: The page is successfully bookmarked and the bookmark icon is grayed out. Notes: Please check the attached screen capture.
Reporter | ||
Updated•10 years ago
|
status-firefox27:
--- → unaffected
status-firefox28:
--- → unaffected
status-firefox29:
--- → unaffected
status-firefox30:
--- → affected
Updated•10 years ago
|
Assignee | ||
Comment 1•10 years ago
|
||
We use multiple states for the same Drawable, so we need to make the Drawable mutable (http://developer.android.com/reference/android/graphics/drawable/Drawable.html#mutate%28%29).
Attachment #8381057 -
Flags: review?(wjohnston)
Assignee | ||
Comment 2•10 years ago
|
||
Note that this isn't actually a regression from bug 965453; we've just been lucky that our existing combination of checkboxes and enabled states hasn't triggered this. I'll leave the blocking dependency for bug 965453 though to make sure this gets uplifted with it.
Updated•10 years ago
|
Attachment #8381057 -
Flags: review?(wjohnston) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/72553da55845
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/72553da55845
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
Updated•10 years ago
|
tracking-fennec: ? → 30+
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•