976099 - Redirect to the current page after sign in

Status: VERIFIED FIXED

(Mozilla Reps Graveyard :: reps.mozilla.org, task)

Description

[Alfredos-Panagiotis Damkalis [:fredy]]

Steps to reproduce:
1. Follow this link https://reps.mozilla.org/u/fredy/
2. Sign in with a rep account (for example to see more details like email of the rep)

What should happen:
Redirect to https://reps.mozilla.org/u/fredy/ being signed in.

What happens:
Redirect to https://reps.mozilla.org/dashboard/ being signed in.

Notes:
This happens when someone signs in on every mozilla reps page (people or event page).
I suggest redirection to dashboard occur only when you sign in on the home page (https://reps.mozilla.org/)

Comment 1

[Giorgos Logiotatidis [:giorgos]]

(In reply to Alfredos-Panagiotis Damkalis [:fredy] from comment #0)
> This happens when someone signs in on every mozilla reps page (people or
> event page).
> I suggest redirection to dashboard occur only when you sign in on the home
> page (https://reps.mozilla.org/)

Yes this should be the case

Comment 2

[Giorgos Logiotatidis [:giorgos]]

We also need to make sure that if:
* you are logged out
* you try to visit a protected page (e.g. /events/new/)
* and you get redirected to / with the "Please login message"
Then if you login
* you are redirected to the protected page you're trying to visit

Comment 3

[jbonatakis]

The first request already works as you excpect. plz chat with me when you are able to help me with the second request.

Comment 4

[ram_0323]

can i work on it

Comment 5

[jbonatakis]

I am almost done with that. I will let you know if nothing change.

Comment 6

[Giorgos Logiotatidis [:giorgos]]

(In reply to ram_0323 from comment #4)
> can i work on it

Hi ram, this is an assigned bug to jbonatakis who's actively working on this. Please go ahead and chose another bug which is unassigned.

Comment 7

[Giorgos Logiotatidis [:giorgos]]

(In reply to jbonatakis from comment #5)
> I am almost done with that. I will let you know if nothing change.

Is there something missing from your implementation and you say you're almost done? If yes, can you please state what?

Comment 8

[jbonatakis]

no anymore @giorgos. Although thank you for asking

Comment 9

[Sagar Pandey]

fredy: Is this still available to take on. I am interested to work on it .

Comment 10

[Tasos Katsoulas [:tasos]]

(In reply to sagarinocean from comment #9)
> fredy: Is this still available to take on. I am interested to work on it .

Hi sagarinocean, this is assigned to jbonatakis who's currently working on this. There is already a pull request [0] for this bug, in case you are interested to monitor the progress.
You are more than welcome to choose another bug which is unassigned. If you need some help choosing a bug, you can join us at #remo-dev on irc [1].

Thanks for your interest in contributing to the ReMo portal!

[0] https://github.com/mozilla/remo/pull/761
[1] https://wiki.mozilla.org/IRC#Connect_to_the_Mozilla_IRC_server

Comment 11

[[github robot]]

Commits pushed to master at https://github.com/mozilla/remo

https://github.com/mozilla/remo/commit/d1912db36ac7cac3848f762fac2c55d5395a185c
[bug 976099] Redirect to the current page after sign in.

https://github.com/mozilla/remo/commit/7c6c884f8b4b637fd8867a8e7298bb1aec1a56cb
Merge pull request #799 from glogiotatidis/976099

[bug 976099] Redirect to the current page after sign in.

Comment 12

[Tasos Katsoulas [:tasos]]

Verified on stage.

Steps:
* Logged out from the portal
* Tried to access reps.allizom.org/voting
* Redirected to main page
* After logging in, I was redirected to the voting page.