Closed Bug 976174 Opened 10 years ago Closed 10 years ago

Better failure message in switch_to_keyboard() and dismiss()

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P3)

x86_64
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: zcampbell, Assigned: zcampbell)

References

Details

Attachments

(1 file)

52 bytes, text/plain
Bebe
: review+
AndreiH
: review+
Details
When the keyboard fails to open, it'd be nice to have a better debug message. The debug message could include the keyboard frame's class and marionette is_displayed interpretation.

I think this could be achieved basically by merging `switch_to_keyboard` and `is_displayed` and then providing a good debug message in the wait failure.


Here is a typical failure which tells us little about the state of the keyboard.


 File "/home/travis/build/mozilla-b2g/gaia/tests/python/gaia-ui-tests/gaiatest/apps/keyboard/app.py", line 208, in send

self.switch_to_keyboard()

File "/home/travis/build/mozilla-b2g/gaia/tests/python/gaia-ui-tests/gaiatest/apps/keyboard/app.py", line 144, in switch_to_keyboard

self.wait_for_condition(lambda m: self.is_displayed())

File "/home/travis/build/mozilla-b2g/gaia/tests/python/gaia-ui-tests/gaiatest/apps/base.py", line 50, in wait_for_condition

Wait(self.marionette, timeout).until(method, message=message)

File "/home/travis/build/mozilla-b2g/gaia/travis_venv/local/lib/python2.7/site-packages/marionette_client-0.7.3-py2.7.egg/marionette/wait.py", line 143, in until

cause=last_exc)

TimeoutException: TimeoutException: Timed out after 10.4737350941 secondsNone

TEST-UNEXPECTED-FAIL | test_clock_add_alarm_multiple_times.py test_clock_add_alarm_multiple_times.TestClockAddAlarmMultipleTimes.test_clock_add_alarm_multiple_times |

----------------------------------------------------------------------

Ran 1 test in 21.671s
Summary: Better failure message in switch_to_keyboard → Better failure message in switch_to_keyboard() and dismiss()
Assignee: nobody → zcampbell
Attached file github pr
Attachment #8381485 - Flags: review?(florin.strugariu)
Attachment #8381485 - Flags: review?(andrei.hutusoru)
Comment on attachment 8381485 [details]
github pr

had 1 question, but the changes LGTM
Attachment #8381485 - Flags: review?(andrei.hutusoru) → review+
Comment on attachment 8381485 [details]
github pr

Looks OK to me
Attachment #8381485 - Flags: review?(florin.strugariu) → review+
https://github.com/mozilla-b2g/gaia/commit/ad9ac6fdb3593c572f74a25497afacc9b2bb3734
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: