976175 - Banner appears on top of non-about:home page during session restore on 2.3

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Margaret Leibovic]

I ran into this when my session was restoring.

Comment 1

[:Margaret Leibovic]

This looks like the same Android 2.3 issue that's causing bug 976176.

Comment 2

[:Margaret Leibovic]

Actually, no, this is a separate issue, but with a similar cause. I'll post a patch here as well.

Comment 3

[:Margaret Leibovic]

Attachment: Initialize home_pager_container view to GONE

The way the banner currently works is that it is set to VISIBLE as soon as there's text to put in it, but it has an initial translation that prevents it from appearing on the screen. During session restore on post-2.3 phones, this seems to take care of making sure the banner show up, but this solution doesn't appear to work on older phones.

However, it feels like a bug that the home_pager_container view isn't hidden when we load a normal page from session restore, since it's hidden if we navigate to that page normally.

Comment 4

[Lucas Rocha (:lucasr)]

Comment on attachment 8380847 [details] [diff] [review]
Initialize home_pager_container view to GONE

Review of attachment 8380847 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense.

Comment 5

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/4f3ea4de80fc

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4f3ea4de80fc

Comment 7

[:Margaret Leibovic]

Comment on attachment 8380847 [details] [diff] [review]
Initialize home_pager_container view to GONE

[Approval Request Comment]
Bug caused by (feature/regressing bug #): snippets and promo banner
User impact if declined: banner will not hide when it should on pre-honeycomb devices
Testing completed (on m-c, etc.): landed on m-c 2/25, tested locally with gingerbread device
Risk to taking this patch (and alternatives if risky): low-risk, tweaks some visibility code
String or IDL/UUID changes made by this patch: none

Comment 8

[:Margaret Leibovic]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e94d36d25bbe