976204 - |Error: TypeError: aMsgHdr is null| in setJunkMsg

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[Jim Porter (:squib)]

Attachment: Fix it

I'm seeing this in the error console:

Error: TypeError: aMsgHdr is null
Source File: chrome://messenger/content/mailWindowOverlay.js
Line: 2843

Here's a fix.

Comment 1

[Magnus Melin [:mkmelin]]

How do you reproduce this?

Comment 2

[Jim Porter (:squib)]

I see it sometimes when I select all messages in a folder. I'm not totally sure why it happens, though.

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 8380772 [details] [diff] [review]
Fix it

Review of attachment 8380772 [details] [diff] [review]:
-----------------------------------------------------------------

Probably from the call at http://mxr.mozilla.org/comm-central/source/mail/base/content/mailWindowOverlay.js#2783

r=mkmelin, but I'm not completely sure i like allowing passing null like that

Comment 4

[Jim Porter (:squib)]

Yeah, I'm cargo-culting the code a bit. If I get a chance (probably post-31, if ever), I might see about cleaning up some of this code a little more thoroughly. At some point I want to refactor a lot of stuff into separate modules so that we don't rely on global state as much.

Comment 5

[Jim Porter (:squib)]

Landed: https://hg.mozilla.org/comm-central/rev/6530473e6f39