Closed Bug 976204 Opened 7 years ago Closed 7 years ago

|Error: TypeError: aMsgHdr is null| in setJunkMsg

Categories

(Thunderbird :: Message Reader UI, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 30.0

People

(Reporter: squib, Assigned: squib)

Details

Attachments

(1 file)

Attached patch Fix itSplinter Review
I'm seeing this in the error console:

Error: TypeError: aMsgHdr is null
Source File: chrome://messenger/content/mailWindowOverlay.js
Line: 2843

Here's a fix.
Attachment #8380772 - Flags: review?(mkmelin+mozilla)
How do you reproduce this?
I see it sometimes when I select all messages in a folder. I'm not totally sure why it happens, though.
Comment on attachment 8380772 [details] [diff] [review]
Fix it

Review of attachment 8380772 [details] [diff] [review]:
-----------------------------------------------------------------

Probably from the call at http://mxr.mozilla.org/comm-central/source/mail/base/content/mailWindowOverlay.js#2783

r=mkmelin, but I'm not completely sure i like allowing passing null like that
Attachment #8380772 - Flags: review?(mkmelin+mozilla) → review+
Yeah, I'm cargo-culting the code a bit. If I get a chance (probably post-31, if ever), I might see about cleaning up some of this code a little more thoroughly. At some point I want to refactor a lot of stuff into separate modules so that we don't rely on global state as much.
Landed: https://hg.mozilla.org/comm-central/rev/6530473e6f39
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 30.0
You need to log in before you can comment on or make changes to this bug.