976248 - Colemak keyboard layout

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, enhancement)

Description

[Szilveszter Liszy]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:27.0) Gecko/20100101 Firefox/27.0 (Beta/Release)
Build ID: 20140203105410

Steps to reproduce:

I didn't find the colemak layout under FXOS. :'((


Actual results:

I coded it myself. :D


Expected results:

Accept my pull request.

Comment 1

[Szilveszter Liszy]

Travis build passed.

Comment 2

[Jan Jongboom [:janjongboom] (inactive)]

Hi Liszy, Please add the pull request as an attachment to this bug report (put a link to the PR as the attachment content); and set the review? flag to me. Thanks!

Comment 3

[Szilveszter Liszy]

Attachment: Pull req

Comment 4

[Szilveszter Liszy]

Hope I did it well. Thank you!

Comment 5

[Szilveszter Liszy]

I'm starting to be a bit impatient. :)

Comment 6

[Jan Jongboom [:janjongboom] (inactive)]

Comment on attachment 8382766 [details] [review]
Pull req

Sorry, I was in Malaysia for an event. Please address the comments in the pull request on GitHub. Also change the commit message to:

Bug 976248 - Add colemak keyboard layout

You can do so by following this guide: https://gist.github.com/janjongboom/7194742

Afterwards, please re-flag me for review. Thanks.

Comment 7

[Szilveszter Liszy]

Attachment: Pull request

I can solved this way due permission problems.

Comment 8

[Szilveszter Liszy]

Pull req updated - build fail bug found.

Comment 9

[Jan Jongboom [:janjongboom] (inactive)]

Comment on attachment 8386338 [details] [review]
Pull request

Hi, I have landed this in master: https://github.com/mozilla-b2g/gaia/commit/8369e5d9b9c73610950949d275e919d7d88f74a6

Thanks for your work :-)

Comment 10

[Szilveszter Liszy]

No, I thank you! :-)