97630 - linespacing too large

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Henrik Gemal]

check the line spacing on this page:
http://www.boomtown.net/articles/art.view.php?id=27458
with IE and with Mozilla.

In IE the linespacing it's normal, on Mozilla it's too large.

build 20010829

Comment 1

[Ashley Bischoff (blog at handcoding.com)]

WFM 2001082909 on Win2k. They look identical for me, between IE and Mozilla.

Comment 2

[Henrik Gemal]

ups wrong URL...

correct:
http://www.boomtown.net/articles/art.list.php?type=pc

Comment 3

[Ashley Bischoff (blog at handcoding.com)]

Ok, I see the bug. 

In View Source, I see code such as:
<table class="contentwidth contentcolor" cellpadding="0" cellspacing="0" border="0">

(which I'm not sure is valid CSS)

-> Style System, but this may end up being evangelism.

Comment 4

[Devoti Paolo]

The right is in the middle.
You can get linespacing too narrow here(win98 2001082608)
http://www.txt.it/intranet/servizi_aziendali.htm

Comment 5

[Louis-Xavier BRUSSET]

I had similar problem (too big linespacing)
on http://www.bmacleod.com/brycegallery.html
But it desapears when I resize my window....
Hope it can help you

Comment 6

[Henrik Gemal]

Attachment: Testcase. Simple html that contain css styles. Lineheight is larger in Mozilla than in IE

Comment 7

[Henrik Gemal]

I just attached is simplified testcase.
IE and Netscape 4.x shows the testcase with a "normal" lineheight while Mozilla 
seems to get too much lineheight.

using 20011012 to test

Comment 8

[Bernd]

setting the lineheight in the testcase to 50px make's it obvious that mozilla
inherits the lineheight into the inner table while the other browser don't do
it. Probably we should cut this inheritance too.

Comment 9

[Bernd]

Attachment: patch

Comment 10

[Henrik Gemal]

Attachment: Sligtly better patch

Comment 11

[Henrik Gemal]

Just tried the patch and it works just fine. All testcases now have the correct
line height!

anybody up for a review and sr?

Comment 12

[Bernd]

Attachment: revised patch

Comment 13

[Bernd]

Attachment: testcase with caption text

Comment 14

[Bernd]

the patch has still to pass the table + block regression tests at
layout\html\tests\block\rtest.bat. Once this is done I will ask Hixie for a
review, or to be more precise: I refuse to touch quirks.css without his approval.

Comment 15

[Bernd]

the patch has passed the regression tests 

Comment 16

[Hixie (not reading bugmail)]

makes sense. r=hixie.
please get your sr from hyatt and module owner approval from karnaze.

Comment 17

[karnaze (gone)]

Comment on attachment 54731 [details] [diff] [review]
revised patch

r=karnaze

Comment 18

[Marc Attinasi]

Comment on attachment 54731 [details] [diff] [review]
revised patch

woo-hoo! sr=attinasi

Comment 19

[Bernd]

fix checked in

Comment 20

[Henrik Gemal]

v 20020221