Closed Bug 976302 Opened 6 years ago Closed 6 years ago

MutationRecord should use mozilla::dom::DOMString

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla30

People

(Reporter: smaug, Assigned: smaug)

Details

Attachments

(2 files)

patch
13.90 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
+ the optimization
13.94 KB, patch
Details | Diff | Splinter Review 
...and DOMString could have a helper method to make this a bit easier.
Attached patch patch — — Splinter Review 
For example like this.
https://tbpl.mozilla.org/?tree=Try&rev=aea683ace9ce
Attachment #8381007 - Flags: review?(bzbarsky)
Comment on attachment 8381007 [details] [diff] [review]
patch

>+    if (aAtom) {

If you made this "if (aNullHandling == eNullNotExpected || aAtom)", could compilers do a better job of optimizing the check away?  Seems like they could, in the case when this is inlined, so the value of aNullHandling is known.

Either way, I guess.

r=me
Attachment #8381007 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/655aaacbacba
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.