976337 - Build routes to user lists that correspond to placenames

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Justin Crawford [:hoosteeno] [:jcrawford]]

We currently have URLs like this:

https://mozillians.org/en-US/country/us/region/colorado/city/denver/
https://mozillians.org/en-US/country/us/region/colorado/
https://mozillians.org/en-US/country/us/

After we implement true geographic data, all of those URLs should still work as expected.

Question:
* Can the URLs be made less verbose, or are they already optimal?

Comment 1

[Andrei Hajdukewycz [:sancus]]

These urls work as expected since: https://github.com/mozilla/mozillians/pull/975

The URLs themselves could be made less verbose by changing 'country', 'region', 'city' to shorter versions, but I think they're clearer as-is and I'm not really concerned with optimizing for url length here.

Comment 2

[Matt Brandt [:mbrandt]]

Reopening for investigation:

- During a transition /us/ became /United%20States/ and is preventing the urls in comment 0 from returning the expected results.
- Should the urls in comment 0 redirect to the new aliases?

The below urls return 0 results:
https://mozillians.org/en-US/country/us/region/colorado/city/denver/
https://mozillians.org/en-US/country/us/region/colorado/
https://mozillians.org/en-US/country/us/

Expected - redirects to?
https://mozillians.org/en-US/country/United%20States/region/Colorado/city/Denver
https://mozillians.org/en-US/country/United%20States/region/Colorado/
https://mozillians.org/en-US/country/United%20States/

Comment 3

[Tasos Katsoulas [:tasos]]

I think that since the initial migration was successful and users can no longer randomly select country, region, city in their profiles, there is no need to use the urls in comment 0. Maybe :giorgos or :sancus can provide more info on this.

Comment 4

[Justin Crawford [:hoosteeno] [:jcrawford]]

I think geographically scoped lists of users, e.g. "Mozillians in Finland", is a valuable view of the data that people should be able to access at descriptive URLs. So I would not agree with taking those routes out of the application. I don't think the redirects required to satisfy comment 2 are strictly necessary.

Comment 5

[William Reynolds [:williamr]]

(In reply to Justin Crawford [:hoosteeno] from comment #4)
> I think geographically scoped lists of users, e.g. "Mozillians in Finland",
> is a valuable view of the data that people should be able to access at
> descriptive URLs. So I would not agree with taking those routes out of the
> application. I don't think the redirects required to satisfy comment 2 are
> strictly necessary.

Agreed. It is valuable to keep the location listing pages we have. It is not strictly necessary to add the redirects required to satisfy comment 2.

I did some investigating in our website analytics and found that there are *very few* (if any) users who are landing on the old location listing URLs.

Comment 6

[William Reynolds [:williamr]]

Attachment: very few visitors finding old URLs

Here's a screenshot showing that fewer than 10 users in the last month visited an outdated location page with country codes instead of country names in the URL.

Comment 7

[Matt Brandt [:mbrandt]]

+1 to comment 4 and comment 6 - using the old resource scheme is not important.

The real bug is the following descriptive urls should return results:

The below urls return 0 results:
https://mozillians.org/en-US/country/us/region/colorado/city/denver/
https://mozillians.org/en-US/country/us/region/colorado/
https://mozillians.org/en-US/country/us/

Comment 8

[Tasos Katsoulas [:tasos]]

Due to the new geographic data, there is no country with the name of 'us'. The only available name in our db is 'United States'. That's the reason why these urls return 0 results. A possible workaround is to map the available names to the normalized one. For example 'us' should be mapped to 'United States' and then perform the actual search. Thoughts?

Comment 9

[Matt Brandt [:mbrandt]]

Opps, I guess I shouldn't do detail work before my first cup of coffee. Tasos, you are spot on, my mistake. I was looking at the wrong urls.

Can we close this bug?

Comment 10

[Tasos Katsoulas [:tasos]]

As per comment 9, I am bumping it to resolved.

Comment 11

[Matt Brandt [:mbrandt]]

Yay .. bumping to QA verified - location urls work as expected