Closed Bug 976394 Opened 6 years ago Closed 6 years ago

NS_QUERY_SELECTED_TEXT on e10s is sometimes wrong value

Categories

(Core :: DOM: Events, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: m_kato, Assigned: m_kato)

Details

Attachments

(1 file, 1 obsolete file)

On e10s, NS_QUERY_SELECTED_TEXT sometimes return invalid data.  When no composition string and no string in editor, offset sometimes returns non-0.

Old Andorid e10s implemetation used selection event for composition.  So NS_QUERY_SELECTED_TEXT depended on selection event.

NS_QUERY_SELECTED_TEXT's range value should be updated per composition event.
Set selection range per composition event, not NOTIFY_SELECTION_CHANGE.  Also, NOTIFY_SELECTION_CHANGE shouldn't be sent by focus change.  So I implements NotityIME for IPC.
Attachment #8381089 - Flags: review?(masayuki)
Comment on attachment 8381089 [details] [diff] [review]
Set selection range per composition event.

I don't understand this patch well yet.

Why do we not need to update selection when JS or a key event changes caret position? If you don't handle the NOTIFY_SELECTION_CHANGE, it means so.
(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #2)
> Comment on attachment 8381089 [details] [diff] [review]
> Set selection range per composition event.
> 
> I don't understand this patch well yet.
> 
> Why do we not need to update selection when JS or a key event changes caret
> position? If you don't handle the NOTIFY_SELECTION_CHANGE, it means so.

Humm, this event doesn't notfiy...  I will reinvestigating...
Attachment #8381089 - Attachment is obsolete: true
Attachment #8381089 - Flags: review?(masayuki)
maybe typo of macro
And could you wait bug 961704? Perhaps, it can land tonight or tomorrow (I hope so!).
Attached patch typoSplinter Review
that was typo :-<.
Attachment #8381150 - Flags: review?(masayuki)
(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #5)
> And could you wait bug 961704? Perhaps, it can land tonight or tomorrow (I
> hope so!).

No, this seems to be typo issue.
Comment on attachment 8381150 [details] [diff] [review]
typo

Oh...
Attachment #8381150 - Flags: review?(masayuki) → review+
https://hg.mozilla.org/mozilla-central/rev/ac32ace7a22e
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.