976421 - Code highlights should work for <img> tags

Status: RESOLVED FIXED

(Webmaker Graveyard :: Thimble, defect)

Description

[Brett Gaylor [:brett]]

Hi, playing with the new code highlighting, I expected the image in this page:
https://etherworks.makes.org/thimble/highlights/remix

Would be highlighted in the editor when I mouseovered in the preview window.

The actual result is that only content within tags that are closed, ie things inside <p>this</p> will highlight, but <img> tags won't, nor will text that isn't inside <p> tags.

Any thoughts? This likely isn't behaviour a user expects.

Comment 1

[Pomax]

interesting. browser console reports "Uncaught TypeError: Cannot read property 'end' of undefined " occuring inside the live preview, I'll have a look at why that is.

Comment 2

[Pomax]

gotcha. <img ....> has no closetag; the code was looking for </img>, which doesn't exist, and the highlighter panicked.

Comment 3

[Pomax]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/370

simple enough fix