Closed
Bug 976443
Opened 10 years ago
Closed 10 years ago
Move -U defines to moz.build
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla30
People
(Reporter: glandium, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
1.99 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #973144 +++
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8381831 -
Flags: review?(mshal)
Attachment #8381831 -
Flags: review?(mh+mozilla)
Attachment #8381831 -
Flags: review?(gps)
|
Reporter | |
Comment 2•10 years ago
|
||
Comment on attachment 8381831 [details] [diff] [review] Move undefines to moz.build Review of attachment 8381831 [details] [diff] [review]: ----------------------------------------------------------------- ::: netwerk/sctp/src/moz.build @@ +89,5 @@ > +if CONFIG['OS_TARGET'] == 'OpenBSD': > + DEFINES['__OpenBSD__'] = False > + > +if CONFIG['OS_TARGET'] == 'DragonFly': > + DEFINES['__DragonFly__'] = False Most of those are actually useless but meh. Feel free to file a followup bug and assign it to :gaston, who added them.
Attachment #8381831 -
Flags: review?(mshal)
Attachment #8381831 -
Flags: review?(mh+mozilla)
Attachment #8381831 -
Flags: review?(gps)
Attachment #8381831 -
Flags: review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a6a0700bf775
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a6a0700bf775
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•