976485 - [bluedroid]Fix sometimes Avrcp 1.3 play status is out of sync

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Sometimes Avrcp 1.3 position bar/play status is out of sync with car kit AVH-X5550BT.

Comment 1

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: btsnoop_hci_nexus5-b2g.cfa

Comment 2

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: btsnoop_hci_nexus5-b2g.cfa

Comment 3

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: btsnoop_hci_hammerhead-aosp.cfa

Comment 4

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

It seems that GetPlayStatus command is interfered by Position Changed Notification. It's not good.

9,936	CT	12	STATUS			VENDOR-DEPENDENT			Get Play Status	Non-Fragmented		22	 00:00:05.008821	2014/2/25 上午 06:35:58.222975	
9,937	TG	12		CHANGED		VENDOR-DEPENDENT			Register Notification	Non-Fragmented		27	 00:00:00.025387	2014/2/25 上午 06:35:58.248362	
9,938	TG	12		IMPLEMENTED/STABLE		VENDOR-DEPENDENT			Get Play Status	Non-Fragmented		31	 00:00:00.000655	2014/2/25 上午 06:35:58.249017

Comment 5

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Whenever, the play status is out of sync. I noticed that log shows bluedroid did not send out get_play_status_rsp. Maybe this is the root cause after enabling bluetooth log.

03-11 07:21:41.507 I/GeckoBluetooth( 2443): UpdatePlayStatus: [AVRCP] Register notification rsp: PLAY_POS_CHANGE, NOTI_CHANGED
03-11 07:21:41.507 I/GeckoBluetooth( 2443): UpdatePlayStatus: [AVRCP] Get play status rsp
03-11 07:21:41.507 W/bt-btif ( 2443): get_play_status_rsp Not sending response as no PDU was registered
03-11 07:21:41.548 I/GeckoBluetooth( 2443): UpdateRegisterNotification: [AVRCP] Register notification rsp: 5 INTERIM

Comment 6

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

I found the warning message is because at that time, no GetPlayStatus query updated. But somehow, we shall send play status update but we didn't. :(

Comment 7

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 976485 - [bluedroid]Fix sometimes Avrcp 1.3 play status is out of sync

Comment 8

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Root cause:
mPlayStatusChangedNotifyType never been updated, which cause play status notification never reached.

Comment 9

[Gina Yeh [:gyeh] [:ginayeh]]

Comment on attachment 8389731 [details] [diff] [review]
Bug 976485 - [bluedroid]Fix sometimes Avrcp 1.3 play status is out of sync

Review of attachment 8389731 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks. :)

Comment 10

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

https://tbpl.mozilla.org/?tree=Try&rev=4f688621b006

Comment 11

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 976485 - [bluedroid]Fix sometimes Avrcp 1.3 play status is out of sync, r=gyeh

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/f351db5f1189

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f351db5f1189