Closed Bug 976513 Opened 10 years ago Closed 10 years ago

Intermittent | browser_panel_toggle.js | Check that panel has panelopen attribute - Got , expected true

Categories

(Firefox :: Toolbars and Customization, defect)

Product:
Firefox
Component:
Toolbars and Customization
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 30
Tracking Flags:
Tracking Status
firefox28 --- unaffected
firefox29 --- fixed
firefox30 --- fixed
firefox-esr24 --- unaffected

People

(Reporter: cbook, Assigned: Gijs)

References

(
URL
)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Australis - yield all the close windows in tests to avoid randomorange, rs=test-only
11.92 KB, patch
Sylvestre
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
Ubuntu ASAN VM 12.04 x64 fx-team opt test mochitest-browser-chrome on 2014-02-24 22:18:38 PST for push a7f45c95831d

slave: tst-linux64-ec2-009

https://tbpl.mozilla.org/php/getParsedLog.php?id=35197476&tree=Fx-Team



TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_panel_toggle.js | Check that panel has panelopen attribute - Got , expected true
Gijs, by my count, we now have 4 different oranges for this test on file (bug 949357, bug 949962, bug 957228, and this one), 3 of which we're hitting regularly. Can we please fix or disable this test soon?
Flags: needinfo?(gijskruitbosch+bugs)
remote:   https://tbpl.mozilla.org/?tree=Try&rev=0fe0b3b98dbe


Assuming this doesn't go orange wholesale, I'll likely push this patch regardless of if it seems to affect this particular failure, as it'll be good to do this.

TBH, this is just my best guess as to how/why this is failing. I've never been able to reproduce this myself (yes, I've looked at this failure before). :-(

Essentially, it seems like the panel is just being closed before it's been fully opened, and I've never been able to figure out why that is. We're running into something similar with bug 947914.
Flags: needinfo?(gijskruitbosch+bugs)
remote:   https://hg.mozilla.org/integration/fx-team/rev/8859e1b0add3


Let's leave this open to see if we're actually fixing stuff.
Keywords: leave-open
It's been 3 days. Given previous rate of failure, I am going to call this.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
status-firefox29: --- → affected
status-firefox30: --- → fixed
Keywords: leave-open
Target Milestone: --- → Firefox 30
Assignee: nobody → gijskruitbosch+bugs
Comment on attachment 8385469 [details] [diff] [review]
Australis - yield all the close windows in tests to avoid randomorange, rs=test-only

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Australis
User impact if declined: none, but massive sheriff unhappiness
Testing completed (on m-c, etc.): on m-c, it fixed our intermittent test failures
Risk to taking this patch (and alternatives if risky): none, test-only
String or IDL/UUID changes made by this patch: none
Attachment #8385469 - Flags: approval-mozilla-aurora?
Attachment #8385469 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
QA Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: