Closed
Bug 976565
Opened 11 years ago
Closed 11 years ago
remove IS_LITTLE_ENDIAN use from MacroAssembler-arm.cpp
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
|
3.10 KB,
patch
|
mjrosenb
:
review+
|
Details | Diff | Splinter Review |
We have better ways of punning doubles nowadays.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8381422 -
Flags: review?(mrosenberg)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8381422 [details] [diff] [review]
remove IS_LITTLE_ENDIAN use from MacroAssembler-arm.cpp
Review of attachment 8381422 [details] [diff] [review]:
-----------------------------------------------------------------
I am sad I can only give this one r+, I really never liked that struct. Can BitwiseCast be used to go between any two objects that are the same size?
Attachment #8381422 -
Flags: review?(mrosenberg) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e4dd4dd96cbe
Yeah, BitwiseCast should work for any two things that are the same size.
Flags: in-testsuite-
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → nfroyd
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•