976576 - [DSDS][SIM Manager] Change the title text for "Data" CTA

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Julien Wajsberg [:julienw]]

See Bug 947139 comment 30:

3. We shall then change the description for Data setting in SIM manager. I'd suggest "Internet connection and Marketplace payments will be set to" (I don't think users will understand what A-GPS is).

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

ni? Carrie for string change proposal

Comment 2

[Carrie Wang [New account: [e-mail]]]

I'd like to change the description to 
Data service network and Marketplace payments 
Assign to Arthur for the string changes.

Thanks!

Comment 3

[Lancelot Nyachoto]

Hi 

I would like to work on this bug with some guidance.

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Lancelot, great to have your support!

To update a string, we need to:
1. Update the string in the html files
2. Update the localization file - change the string and the corresponding string id. We need a new string id every time we change a string.

In this case we need to modify apps/settings/elements/sim_manager.html and apps/settings/locales/settings.en-US.properties.

Comment 5

[Lancelot Nyachoto]

Thanks Arthur

Can I make the string id anything I think is appropriate or are there guidelines on this?

Comment 6

[Lancelot Nyachoto]

Here are the changes that I have made, just want to run this by you before making a pull request.

https://github.com/kombuta/gaia/commit/b3c0b64721e8816418f0c23044aede37b71f2167

Comment 7

[Julien Wajsberg [:julienw]]

Just do a pull request and request feedback or review to Arthur :) That's how we work here, pull requests are not necessarily ready. Thanks !

Comment 8

[Lancelot Nyachoto]

Attachment: Pull Request-17941

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8401174 [details] [review]
Pull Request-17941

Thanks for the patch. It looks good to me. However, if I remember correctly we've ever used "sim-manager-outgoing-data-desc" as the string id before. Suggest to use another string id.

Also flagging l10n team to check if this is okay.

Comment 10

[Francesco Lodolo [:flod]]

Better change it, the string was used in 1.3
https://github.com/mozilla-b2g/gaia/blob/v1.3/apps/settings/locales/settings.en-US.properties#L561

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8401174 [details] [review]
Pull Request-17941

Per comment 10, please use a new id and request a review again when ready, thanks.

Comment 12

[Lancelot Nyachoto]

Comment on attachment 8401174 [details] [review]
Pull Request-17941

Changed String ID

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8401174 [details] [review]
Pull Request-17941

f=me. Please squash the commits into one before the patch is ready to be merged. Refer to this article for squashing. (http://ariejan.net/2011/07/05/git-squash-your-latests-commits-into-one/)

Comment 14

[Lancelot Nyachoto]

Thanks for that tip Arthur. I have squashed the commits into one.

Comment 15

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8401174 [details] [review]
Pull Request-17941

r=me, thank you for the effort!

Comment 16

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: 34ecb1d8871e292500e0cde0b7de34a0d69ad755