976589 - Use build date, not nightly date in dashboard

Status: RESOLVED FIXED

(Testing Graveyard :: Eideticker, defect)

Description

[William Lachance (:wlach)]

Currently the dashboard is built to use a date like "2013-02-02" for ordering results, which corresponds to the date of a nightly. But it seems like with b2g now, we can have multiple nightlies, as we see today (the 24th) here:

http://eideticker.wrla.ch/b2g/#/inari/b2g-contacts-startup/timetostableframe

Honestly, this was never a really good scheme. Instead, we should move to using a build timestamp for ordering results. That'll fix this problem and is an incremental step towards being able to generate results more frequently for both Android and FirefoxOS.

Comment 1

[William Lachance (:wlach)]

Attachment: Use build date, not nightly date in dashboard;r=davehunt

Comment 2

[William Lachance (:wlach)]

Note that we will need to run some kind of script to convert the existing dashboard schema into timestamps before this lands. Should be pretty trivial.

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

See also bug 960661

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8381797 [details] [diff] [review]
Use build date, not nightly date in dashboard;r=davehunt

Review of attachment 8381797 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with or without the comment addressed.

::: src/eideticker/eideticker/metadata.py
@@ +20,5 @@
> +    (year, month, day, hour, minute, second) = map(lambda x: int(x),
> +                                                   (buildid[0:4], buildid[4:6],
> +                                                    buildid[6:8], buildid[8:10],
> +                                                    buildid[10:12], buildid[12:14]))
> +    date = datetime.datetime(year, month, day, hour, minute, second)

Could we use strptime here? http://docs.python.org/2/library/time.html#time.strptime

structTime = time.strptime(buildid, '%Y%m%d%H%M%S')
datetime.datetime(*structTime[:6])

Comment 5

[William Lachance (:wlach)]

Landed this patch with a few minor changes (suggested + a few updates to how we display dates in the dash):

https://github.com/mozilla/eideticker/commit/f80902d074bcd1be9a15cb84e827e74231c9973b

You can see the new dashboard with correct dates at http://eideticker.mozilla.org/b2g

Comment 6

[William Lachance (:wlach)]

Attachment: Script for converting dates

For posterity, here's the script I used to convert the old b2g dashboard to the new format.

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Will, is there anything else to do here, or can we mark this as resolved?

Comment 8

[William Lachance (:wlach)]

Sorry, yeah, meant to resolve this.