Closed Bug 976638 Opened 7 years ago Closed 7 years ago
New tab controls
.png should be the same across platforms
From bug 974736 comment 17, the new tab controls should be the same across windows, osx, linux; but they're slightly different: - pins pointing down vs diagonally - shadow - contrast of tiles toggle Which set of icons are desired? We can make it consistent in fixing bug 974736.
Our current patches take the mac controls.png: https://bugzilla.mozilla.org/attachment.cgi?id=8381140&action=edit It's the one with down pins when pinned. Is that acceptable, shorlander?
Boriss, bug 974736 fixes this by using the mac icons and putting it in the shared directory for windows and linux. Just confirming that decision is okay.
Flags: needinfo?(shorlander) → needinfo?(jboriss)
Assignee: nobody → jboriss
Whiteboard: [tiles] p=0 → [tiles] p=2 s=it-30c-29a-28b.3
Whiteboard: [tiles] p=2 s=it-30c-29a-28b.3 → [tiles] p=2 s=it-30c-29a-28b.3 [qa+]
(In reply to Ed Lee :Mardak from comment #2) > Boriss, bug 974736 fixes this by using the mac icons and putting it in the > shared directory for windows and linux. Just confirming that decision is > okay. Yep, that's ok!
Marking this as invalid per Comment 2: we'll be using a shared directory for these files.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
Assignee: jboriss → nobody
QA Contact: twalker
Whiteboard: [tiles] p=2 s=it-30c-29a-28b.3 [qa+]
This bug is something that needs to be fixed. We happen to be fixing it in bug 974736. I'll resolve this bug when the code there lands.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Assignee: nobody → mzhilyaev
Target Milestone: --- → Firefox 31
Whiteboard: p=0 s=it-31c-30a-29b.2 → p=2 s=it-31c-30a-29b.2
Florin, can you assign this to someone on your team? Thanks!
Whiteboard: p=2 s=it-31c-30a-29b.2 → p=2 s=it-31c-30a-29b.2 [qa+]
No longer blocks: fxdesktopbacklog
QA Contact: cornel.ionce
Verified in latest Nightly (build ID: 20140402030201) that the new tab controls are the same across platform. The controls are the ones from https://bugzilla.mozilla.org/attachment.cgi?id=8381140. Testing was performed on Windows 7 64bit, Ubuntu 12.4 32bit, Mac OS X 10.9 and Windows 8.1 64bit (MS Surface Pro 2).
Status: RESOLVED → VERIFIED
Whiteboard: p=2 s=it-31c-30a-29b.2 [qa+] → p=2 s=it-31c-30a-29b.2 [qa!]
You need to log in before you can comment on or make changes to this bug.