Closed
Bug 976651
Opened 10 years ago
Closed 10 years ago
Encapsulate the Read of a new nsXBLPrototypeBinding a little better
Categories
(Core :: XBL, defect)
Core
XBL
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: mccr8, Assigned: mccr8)
Details
Attachments
(1 file)
3.95 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
The current set up with ReadPrototypeBindings is scary looking: we allocate an object, and then call Read on it. If the Read fails, we delete the object. Implementing this requires things like basically forgetting an auto pointer. I think it is cleaner to at least hide that nastiness in nsXBLPrototypeBinding itself, rather than this weird lifetime being exposed in nsXBLDocumentInfo.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8381916 -
Flags: review?(mrbkap)
Updated•10 years ago
|
Attachment #8381916 -
Flags: review?(mrbkap) → review+
Assignee | ||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1238bfc6607b
https://hg.mozilla.org/mozilla-central/rev/1238bfc6607b
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•