Closed Bug 976651 Opened 6 years ago Closed 6 years ago

Encapsulate the Read of a new nsXBLPrototypeBinding a little better

Categories

(Core :: XBL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: mccr8, Assigned: mccr8)

Details

Attachments

(1 file)

The current set up with ReadPrototypeBindings is scary looking: we allocate an object, and then call Read on it. If the Read fails, we delete the object. Implementing this requires things like basically forgetting an auto pointer. I think it is cleaner to at least hide that nastiness in nsXBLPrototypeBinding itself, rather than this weird lifetime being exposed in nsXBLDocumentInfo.
Attachment #8381916 - Flags: review?(mrbkap) → review+
https://hg.mozilla.org/mozilla-central/rev/1238bfc6607b
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.