976651 - Encapsulate the Read of a new nsXBLPrototypeBinding a little better

Status: RESOLVED FIXED

(Core :: XBL, defect)

Description

[Andrew McCreight [:mccr8]]

The current set up with ReadPrototypeBindings is scary looking: we allocate an object, and then call Read on it. If the Read fails, we delete the object. Implementing this requires things like basically forgetting an auto pointer. I think it is cleaner to at least hide that nastiness in nsXBLPrototypeBinding itself, rather than this weird lifetime being exposed in nsXBLDocumentInfo.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Encapsulate the Read of a new nsXBLPrototypeBinding::Read a little better.

Comment 2

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1238bfc6607b

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1238bfc6607b