976665 - [B2G][Cost Control] Data Usage app has UI issue where white line is shown at bottom of screen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Brogan Zumwalt [Inactive]]

Description:
After user sets up data usage/cost control app, a white line appears on the bottom of screen after editing usage limit. This line persists throughout app, but only appears in usage app.

Repro Steps:
1) Updated Buri to BuildID: 20140225040205
2) Launch Usage app
3) Go through setup and enable "Data use alert"
4) Select gear icon in top right corner
5) Tap limit number under "When use is above"; Observe white line between text box and keypad
6) Select "Done"; Observe white line is still visible at bottom of screen
7) Press "Reset"; White line is very visible at bottom of screen

Actual:
After editing data use limit in cost control app, white line is visible at bottom of screen.

Expected:
No UI issues visible in Usage app.

Environmental Variables:
Device: Buri v1.4 Master Mozilla RIL
BuildID: 20140225040205
Gaia: e0f39c7179c8b297326c0e2313950610be1f5c52
Gecko: e3daaa4c73dd
Version: 30.0a1
Firmware Version: V1.2-device.cfg

Notes:
Repro frequency: 3/3, 100%
See attached: screenshot

Comment 1

[Brogan Zumwalt [Inactive]]

Attachment: Screenshot - Annotated

Comment 2

[Brogan Zumwalt [Inactive]]

Issue also occurs on latest 1.3

Result:
After editing data use limit in cost control app, white line is visible at bottom of screen.

Environmental Variables:
Device: Buri v1.3 Mozilla RIL
BuildID: 20140225004004
Gaia: 6e883bde818d4d53aef7b5b075b4b34267918360
Gecko: e597280f9300
Version: 28.0
Firmware Version: V1.2-device.cfg

Comment 3

[Joan Leon [:joan]]

Attachment: Patch in GitHub

Comment 4

[Joan Leon [:joan]]

Comment on attachment 8382059 [details]
Patch in GitHub

Fix iframe height 100%

Comment 5

[Joan Leon [:joan]]

Attachment: Patch in GitHub

Comment 6

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 8382076 [details] [review]
Patch in GitHub

That solves the issue. Thanks Joan!

Comment 7

[Joan Leon [:joan]]

To solve this issue only added a css attribute in a rule, so no problem that affects other parts of the app.

Comment 8

[Joan Leon [:joan]]

Hi Fabrice,

It's possible to land this patch on master?

Thanks

Comment 9

[[:fabrice] Fabrice Desré]

(In reply to Joan Leon from comment #8)
> Hi Fabrice,
> 
> It's possible to land this patch on master?
> 
> Thanks

Yes, you can land - just have good test coverage, and don't break anything.

Comment 10

[Anthony Ricaud (:rik)]

Please don't forget to add the bug number in the commit message. It's ok here because the bug number is in the comments of the patch.

Comment 11

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

looks like the patch is : https://github.com/mozilla-b2g/gaia/commit/d5fd4c5083a85d877df54e27a8db30b1b015454a


Would this be risky to uplift to 1.3, 1.3t?
It doesn't seem like it.

Noming for backup/uplift.

Comment 12

[Joe Cheng [:jcheng] (please needinfo)]

triage: user impact not high, let's limit the number of fixes going into tarako now