Closed Bug 976665 Opened 7 years ago Closed 7 years ago

[B2G][Cost Control] Data Usage app has UI issue where white line is shown at bottom of screen

Categories

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v1.3 affected, b2g-v1.3T affected, b2g-v1.4 fixed, b2g-v2.0 fixed)

RESOLVED FIXED
1.4 S2 (28feb)
Tracking Status
b2g-v1.3 --- affected
b2g-v1.3T --- affected
b2g-v1.4 --- fixed
b2g-v2.0 --- fixed

People

(Reporter: bzumwalt, Assigned: joan)

Details

Attachments

(2 files, 1 obsolete file)

Description:
After user sets up data usage/cost control app, a white line appears on the bottom of screen after editing usage limit. This line persists throughout app, but only appears in usage app.

Repro Steps:
1) Updated Buri to BuildID: 20140225040205
2) Launch Usage app
3) Go through setup and enable "Data use alert"
4) Select gear icon in top right corner
5) Tap limit number under "When use is above"; Observe white line between text box and keypad
6) Select "Done"; Observe white line is still visible at bottom of screen
7) Press "Reset"; White line is very visible at bottom of screen

Actual:
After editing data use limit in cost control app, white line is visible at bottom of screen.

Expected:
No UI issues visible in Usage app.

Environmental Variables:
Device: Buri v1.4 Master Mozilla RIL
BuildID: 20140225040205
Gaia: e0f39c7179c8b297326c0e2313950610be1f5c52
Gecko: e3daaa4c73dd
Version: 30.0a1
Firmware Version: V1.2-device.cfg

Notes:
Repro frequency: 3/3, 100%
See attached: screenshot
Attached image Screenshot - Annotated
Issue also occurs on latest 1.3

Result:
After editing data use limit in cost control app, white line is visible at bottom of screen.

Environmental Variables:
Device: Buri v1.3 Mozilla RIL
BuildID: 20140225004004
Gaia: 6e883bde818d4d53aef7b5b075b4b34267918360
Gecko: e597280f9300
Version: 28.0
Firmware Version: V1.2-device.cfg
Attached file Patch in GitHub (obsolete) —
Assignee: nobody → joan.leon
Comment on attachment 8382059 [details]
Patch in GitHub

Fix iframe height 100%
Attachment #8382059 - Flags: review?(arnau)
Attached file Patch in GitHub
Attachment #8382059 - Attachment is obsolete: true
Attachment #8382059 - Flags: review?(arnau)
Attachment #8382076 - Flags: review?(arnau)
Comment on attachment 8382076 [details] [review]
Patch in GitHub

That solves the issue. Thanks Joan!
Attachment #8382076 - Flags: review?(arnau) → review+
To solve this issue only added a css attribute in a rule, so no problem that affects other parts of the app.
Flags: in-testsuite-
Flags: needinfo?(fabrice)
Hi Fabrice,

It's possible to land this patch on master?

Thanks
(In reply to Joan Leon from comment #8)
> Hi Fabrice,
> 
> It's possible to land this patch on master?
> 
> Thanks

Yes, you can land - just have good test coverage, and don't break anything.
Flags: needinfo?(fabrice)
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Please don't forget to add the bug number in the commit message. It's ok here because the bug number is in the comments of the patch.
Target Milestone: --- → 1.4 S2 (28feb)
looks like the patch is : https://github.com/mozilla-b2g/gaia/commit/d5fd4c5083a85d877df54e27a8db30b1b015454a


Would this be risky to uplift to 1.3, 1.3t?
It doesn't seem like it.

Noming for backup/uplift.
blocking-b2g: --- → 1.3T?
triage: user impact not high, let's limit the number of fixes going into tarako now
blocking-b2g: 1.3T? → ---
You need to log in before you can comment on or make changes to this bug.