Closed
Bug 976688
Opened 10 years ago
Closed 2 years ago
Add intrinsic for comparing known atoms that is optimized by ion into a pointer comparison
Categories
(Core :: JavaScript Engine: JIT, defect, P5)
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: nmatsakis, Unassigned)
References
Details
(Keywords: perf, Whiteboard: [js:p2])
Attachments
(1 file)
|
3.61 KB,
patch
|
Details | Diff | Splinter Review |
In the typed object code, we attach an atomized string to each type object. These strings are equal iff the two type objects are structurally equivalent. We currently compare them with `===`. This could be made faster because we KNOW by construction that the strings are always atoms. Near as I can tell, TI doesn't track this information, and hence the jit can't optimize it. We could add this kind of thing to TI, which might be useful more generally, but in this particular case an intrinsic `AtomsEq` that is inlined in ion would also be enough.
|
Reporter | |
Updated•10 years ago
|
Blocks: harmony:typedobjects
|
|
Reporter | |
Comment 1•10 years ago
|
||
This is a WIP patch that does not include the jit integration. I am not sure if this is a real perf. bottleneck and just wanted to attach this patch somewhere.
|
||
Updated•8 years ago
|
Priority: -- → P5
|
||
Comment 2•2 years ago
|
||
No longer relevant. Self-hosted TypedObject code has been removed.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•