976723 - Selection handle scrolls outside boundary of <input> on page scroll

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: screenshot.png

Currently one can scroll a selection handle outside the boundary of an <input> on page scroll


1) Visit https://support.mozilla.org, open the side menu and place focus into the search box

2) Type anything to reveal a selection handle and then scroll the left hand side of page content

See the cursor selection handle float away.

See screenshot where the handle is literally pushed off the screen.

Comment 1

[Mark Capella [:capella]]

Attachment: bug976723.diff (v0)

This ones been nagging @ me for a while, and I finally hit on this solution ...

Comment 2

[Mark Capella [:capella]]

Attachment: bug976723.diff (v1)

After playing around with it, this simpler patch works better than what I was going for in the original patch.

Comment 3

[:Margaret Leibovic]

Comment on attachment 8398891 [details] [diff] [review]
bug976723.diff (v1)

Review of attachment 8398891 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, way simpler :) r+ with comment addressed.

::: mobile/android/chrome/content/SelectionHandler.js
@@ +207,5 @@
> +        sendMessageToJava({
> +          type: "TextSelection:PositionHandles",
> +          positions: this._getHandlePositions(this._getScrollPos()),
> +          rtl: this._isRTL
> +        });

I think it would be better to just call this._positionHandles() here, since that method abstracts away this message sending.

I realize that _positionHandles also calls _updateMenu now, which we don't want to happen when we scroll, but that should be fixed by bug 988471 (that bug could also use some love if you're looking for something new to work on :).

Comment 4

[Mark Capella [:capella]]

hehe - You saw what I did there :)

Push to try https://tbpl.mozilla.org/?tree=Try&rev=22846a5d2c62

Comment 5

[Mark Capella [:capella]]

https://hg.mozilla.org/integration/fx-team/rev/ba893b9fd2af

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ba893b9fd2af

Comment 7

[Firefox Commit Bot]

The following changeset is now in Firefox Nightly:

> ba893b9fd2af Bug 976723 - Selection handle scrolls outside boundary of <input> on page scroll, r=margaret

Nightly Build Information:

        ID: 20140402030201
 Changeset: 4941a2ac0786109b08856738019b016a6c5a66a6
   Version: 31.0a1
      TBPL: https://tbpl.mozilla.org/?rev=4941a2ac0786
       URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central

Download Links:

>         Linux x86: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-i686.tar.bz2
>      Linux x86_64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64.tar.bz2
> Linux x86_64 ASAN: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64-asan.tar.bz2
>               Mac: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.mac.dmg
>             Win32: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win32.installer.exe
>             Win64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win64-x86_64.installer.exe

Previous Nightly Build Information:

        ID: 20140401030203
 Changeset: 1417d180a1d8665b1a91b897d1cc4cc31e7980d4
   Version: 31.0a1
      TBPL: https://tbpl.mozilla.org/?rev=1417d180a1d8
       URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-01-03-02-03-mozilla-central