976791 - [B2G][Keyboard] Portuguese: '#' not available on the Portuguese keyboard

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Roland Kunkel [:RolandK]]

Attachment: keboardLayouts_Portuguese.png

Description:
When the device's language is set to Portuguese and it's keyboard is set to Portuguese, the '#' key will not be available to the user

Repro Steps:
1) Update Buri to v1.3 BuildID: 20140220004002
2) Open the Message app
3) Begin a new message
4) Try and type the '#' key

Actual:
The '#' key is not available to the Portuguese keyboard

Expected:
For the '#' to be available to the Portuguese keyboard

Environmental Variables:
Device: Buri 1.2 MOZ
BuildID: 20140220004002
Gaia: 539a25e1887b902b8b25038c547048e691bd97f6
Gecko: 2ea6a65eea23
Version: 26.0
Firmware Version: V1.2-device.cfg

Repro frequency: 100%
Link to failed test case:
See attached: Screenshots

Comment 1

[Delphine Lebédel [:delphine - Use needinfo]]

Adding David and Kevin to this bug
Nominating as this seems pretty bad

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

This regression was caused by bug 936565, which remove symbol layout page of Portuguese, so it would fallback to use the default one, and the default one does not have '#' character.

Comment 3

[Reuben Morais [:reuben]]

I don't get it. We inherit the symbol layout from en-US, which does have the '#' symbol. I can't reproduce this bug, on my phone I get the same symbol layout as the English keyboard.

Comment 4

[Reuben Morais [:reuben]]

Nevermind, for some reason just switching the language to pt-BR in Settings wasn't enough.

Comment 5

[Reuben Morais [:reuben]]

Attachment: Some adjustments to the pt-BR layout

Comment 6

[David Flanagan [:djf]]

Comment on attachment 8382400 [details] [review]
Some adjustments to the pt-BR layout

Reuben,

It looks like you're just making the alternates layout in pt_br follow the layout in en_us, exept that $ becomes R$, and you aren't putting the comma and period around the spacebar.  If those are the changes you're making, it would be helpful to say so instead of just "some adjustments".

The changes seem fine to me. I've marked one nit on Github.

I don't feel that I've got authority to authorize this sort of localization change.  Delphine, is this something you can sign off on?

Comment 7

[Delphine Lebédel [:delphine - Use needinfo]]

Nope sorry! Maybe Pike can? Adding him

Comment 8

[Reuben Morais [:reuben]]

For clarification: I changed the symbols layout to match the en-US keyboard. The locale differences in the main layout (` before ˆ before ´ before ¨, ç before ć, etc) remain there.

David, thanks for the review. I've addressed the nits and will update the commit message. FWIW, I feel like the layouts should be in the l10n repos.

Comment 9

[Delphine Lebédel [:delphine - Use needinfo]]

Note: this is a regression, can we have this 1.3+ed please?

Comment 10

[Axel Hecht [:Pike]]

Reuben being a key contributor of ours in Brazil, I think he's best suited to make the call here on the layout.

Side comment, I strongly believe that keyboard layouts should not be part of the l10n repos. I think it's good that the keyboard selection is independent from the UI locale set selection.

Comment 11

[Reuben Morais [:reuben]]

Merged: https://github.com/mozilla-b2g/gaia/commit/0385d529cc3e71c1f82db9bf71351b578a48dbce

Comment 12

[Reuben Morais [:reuben]]

Comment on attachment 8382400 [details] [review]
Some adjustments to the pt-BR layout

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 936565
[User impact] if declined: '#' not available in the keyboard
[Testing completed]: Manual testing, passes Travis
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: None

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v1.3: dbb2f0390fe8f8158ce27103207987770cfd0f59

Comment 14

[Reuben Morais [:reuben]]

(In reply to Axel Hecht [:Pike] from comment #10)
> Side comment, I strongly believe that keyboard layouts should not be part of
> the l10n repos. I think it's good that the keyboard selection is independent
> from the UI locale set selection.

I also think that's a good thing. Why would putting the keyboard layout in the locale repo change anything about it?

Comment 15

[Francesco Lodolo [:flod]]

(In reply to Reuben Morais [:reuben] from comment #14)
> I also think that's a good thing. Why would putting the keyboard layout in
> the locale repo change anything about it?

You can't ship the keyboard if you don't ship that specific locale (or at least that's how I see it).