976794 - Build news datatype and display on dashboard

Status: VERIFIED FIXED

(Firefox Affiliates Graveyard :: affiliates.mozilla.org, defect)

Description

[Justin Crawford [:hoosteeno] [:jcrawford]]

Reference the file "dashboard-desktop" in bug 972909 and the dashboard design in bug 945866. 

Specs:
    * News items have a headline and a body, and perhaps other fields (see discussion below)
    * News body field accepts markdown with whitelist of tags
    * News headline and body text can be in any language

Mozillians has an implementation of whitelisted markdown: https://github.com/mozilla/mozillians/commit/945bb92d764b074300b5c783227d499856d8a6a7

Comment 1

[Justin Crawford [:hoosteeno] [:jcrawford]]

Questions about news items:

        * will there always or almost always be an image?
        * will the image always be the same size?
        * do we really need a button for the CTA, or would a regular old link do? 
        * if we need a button will there always be a button?
        * what other kinds of markup might be required? strong, emphasis, links, paragraph tags ... ?

Comment 2

[Chelsea Novak [:chelsea]]

(In reply to Justin Crawford [:hoosteeno] from comment #1)
> Questions about news items:
> 
>         * will there always or almost always be an image?
Ideally, but it shouldn't be a blocker on content. 
>         * will the image always be the same size?
There should be a size limit or an ideal size for the layout. 
>         * do we really need a button for the CTA, or would a regular old
> link do? 
It doesn't have to be a button. A link should be okay. If we can embed an image we could add a button for really important CTAs. 
>         * if we need a button will there always be a button?
There will almost always be a CTA of some kind and a link to more info. 
>         * what other kinds of markup might be required? strong, emphasis,
> links, paragraph tags ... ?
All of the above. Strong, emphasis, italic, href, paragraph, maybe a table from time to time. So long as it covers basic html we should be good.

Comment 3

[Osmose [:osmose, :mkelly]]

Just a note, chelsea agreed that we don't need to bother with markdown and can just do straight HTML for the input.

Comment 4

[Justin Crawford [:hoosteeno] [:jcrawford]]

This bug is incorporated in the Affiliates 2.0 release currently live in dev: https://affiliates-dev.allizom.org/

Comment 5

[Matt Brandt [:mbrandt]]

Marking as [qa-] - since this is an admin facing feature I would suggest that a team member who will be using this feature regularly be the one to verify that it meets their needs.

Comment 6

[Justin Crawford [:hoosteeno] [:jcrawford]]

Attachment: News item is shown in dashboard

Verified.

1. News item: https://affiliates-dev.allizom.org/admin/base/newsitem/2/

2. Displayed in dashboard with HTML intact (see attached)

Comment 7

[Justin Crawford [:hoosteeno] [:jcrawford]]

Attachment: Translated news item is shown at proper locale URL

3. A localized version of the news is shown at a locale URL (https://affiliates-dev.allizom.org/es/dashboard/)