976831 - Marionette getStatus appears to be dead code.

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[David Burns :automatedtester]

from webdriver f2f it appears that we may have dead code and we should probably remove it.

Comment 1

[David Burns :automatedtester]

https://tbpl.mozilla.org/?tree=Try&rev=139d928b6939
https://tbpl.mozilla.org/?tree=Try&rev=35ae20bcbb52

Comment 2

[David Burns :automatedtester]

Attachment: Remove unused getStatus method from Marionette;

Comment 3

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 8382293 [details] [diff] [review]
Remove unused getStatus method from Marionette;

Review of attachment 8382293 [details] [diff] [review]:
-----------------------------------------------------------------

r+ if you address comment.

::: testing/marionette/marionette-server.js
@@ -621,5 @@
>     * @param object aRequest
>     *        'value' member holds log message
>     *        'level' member hold log level
>     */
>    log: function MDA_log(aRequest) {

You're missing the line to remove it from MarionetteServerConnection.prototype.requestTypes

Comment 4

[David Burns :automatedtester]

Attachment: Remove unused getStatus method from Marionette;

Comment 5

[David Burns :automatedtester]

Comment on attachment 8382297 [details] [diff] [review]
Remove unused getStatus method from Marionette;

Review of attachment 8382297 [details] [diff] [review]:
-----------------------------------------------------------------

carrying review forward

Comment 6

[David Burns :automatedtester]

landed in https://hg.mozilla.org/integration/mozilla-inbound/rev/b76b74805372

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b76b74805372