Closed Bug 976898 Opened 6 years ago Closed 6 years ago

Move the sdkdecls.h force-include out of the build system

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla30

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → ehsan
Comment on attachment 8381859 [details] [diff] [review]
Move the sdkdecls.h force-include out of the build system

My tree seems to build with this patch, but please double check things since I've already broken this code at least once!  :-)
Attachment #8381859 - Flags: review?(netzen)
Comment on attachment 8381859 [details] [diff] [review]
Move the sdkdecls.h force-include out of the build system

Review of attachment 8381859 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay, I've been in OSX and didn't have a chance to test it right away.

This should probably go through a build peer, but I'm fine with it. I tested it and it works.
I'll leave that to your discretion though.
Attachment #8381859 - Flags: review?(netzen) → review+
Comment on attachment 8381859 [details] [diff] [review]
Move the sdkdecls.h force-include out of the build system

I don't know if there is anything interesting here to get a build peer review for, but I guess I can do that for formality's sake.
Attachment #8381859 - Flags: review?(mshal)
Attachment #8381859 - Flags: review?(mh+mozilla)
Attachment #8381859 - Flags: review?(gps)
Comment on attachment 8381859 [details] [diff] [review]
Move the sdkdecls.h force-include out of the build system

Review of attachment 8381859 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla-config.h.in
@@ +57,5 @@
> + * Note that this include path relies on the LOCAL_INCLUDES in that file.
> + */
> +#if defined(CHROMIUM_SANDBOX_BUILD) && defined(XP_WIN)
> +#include "base/shim/sdkdecls.h"
> +#endif

Man, this file is becoming a garbage collector :(
Attachment #8381859 - Flags: review?(mshal)
Attachment #8381859 - Flags: review?(mh+mozilla)
Attachment #8381859 - Flags: review?(gps)
Attachment #8381859 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/54bf6247cc5f
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.