976914 - Port MOZ_GLUE_LDFLAGS and MOZ_GLUE_PROGRAM_LDFLAGS to moz.build under the name of NO_MOZGLUE

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Comment 1

[(no longer active)]

Attachment: Port MOZ_GLUE_LDFLAGS and MOZ_GLUE_PROGRAM_LDFLAGS to moz.build under the name of NO_MOZGLUE

Comment 2

[Mike Hommey [:glandium]]

This patch looks incomplete.

Comment 3

[Mike Hommey [:glandium]]

That said, I think i'd rather leave that alone for now, at least until i'm done with the library linking stuff.

Comment 4

[(no longer active)]

Comment on attachment 8381881 [details] [diff] [review]
Port MOZ_GLUE_LDFLAGS and MOZ_GLUE_PROGRAM_LDFLAGS to moz.build under the name of NO_MOZGLUE

Wrong patch.

Comment 5

[(no longer active)]

Attachment: Port MOZ_GLUE_LDFLAGS and MOZ_GLUE_PROGRAM_LDFLAGS to moz.build under the name of NO_MOZGLUE

Comment 6

[(no longer active)]

(In reply to Mike Hommey [:glandium] from comment #3)
> That said, I think i'd rather leave that alone for now, at least until i'm
> done with the library linking stuff.

Hmm, why is that?

Comment 7

[Mike Hommey [:glandium]]

(In reply to :Ehsan Akhgari (needinfo? me!) (slow responsiveness, emailapocalypse) from comment #6)
> (In reply to Mike Hommey [:glandium] from comment #3)
> > That said, I think i'd rather leave that alone for now, at least until i'm
> > done with the library linking stuff.
> 
> Hmm, why is that?

Because i might kill requiring MOZ_GLUE_LDFLAGS and MOZ_GLUE_PROGRAM_LDFLAGS.

Comment 8

[(no longer active)]

(In reply to Mike Hommey [:glandium] from comment #7)
> (In reply to :Ehsan Akhgari (needinfo? me!) (slow responsiveness,
> emailapocalypse) from comment #6)
> > (In reply to Mike Hommey [:glandium] from comment #3)
> > > That said, I think i'd rather leave that alone for now, at least until i'm
> > > done with the library linking stuff.
> > 
> > Hmm, why is that?
> 
> Because i might kill requiring MOZ_GLUE_LDFLAGS and MOZ_GLUE_PROGRAM_LDFLAGS.

Then you can remove these from the moz.build files instead of the Makefiles.  There would be fewer things to remove, so your job will actually become easier.

Comment 9

[(no longer active)]

We determined on irc that glandium won't take this patch.

Comment 10

[Michael Shal [:mshal]]

Comment on attachment 8381896 [details] [diff] [review]
Port MOZ_GLUE_LDFLAGS and MOZ_GLUE_PROGRAM_LDFLAGS to moz.build under the name of NO_MOZGLUE

Unflagging review per #c9.