976938 - Add a way to go from an Xray's method to the global of the underlying object

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Boris Zbarsky [:bzbarsky]]

This is needed for bug 976305.

Comment 1

[Bobby Holley (:bholley)]

Attachment: Add a way to identify the Xray parent (if any) of a given function. v1

Naming isn't great, but I really couldn't come up with something better.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8383426 [details] [diff] [review]
Add a way to identify the Xray parent (if any) of a given function. v1

>           JS::Rooted<JSObject*> global(cx, JS_GetGlobalForObject(cx, wrapper));

This is unused after this patch.  Nix it?

>+XrayFunctionParentOrNull(JSObject *fun)

In practice, what we will always want is the callee global, right?  Would it make sense to just have an XrayAwareCalleeGlobal API that does that?

If we do want the API that returns the Xray itself, I can live with this naming.

Also, I really hope this method is reasonably fast, since we'll need to sprinkle it about.  :(

Comment 3

[Bobby Holley (:bholley)]

Attachment: Add a way to identify the Xray parent (if any) of a given function. v2

Comment 4

[Bobby Holley (:bholley)]

https://tbpl.mozilla.org/?tree=Try&rev=5edbffe3bd60

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8384891 [details] [diff] [review]
Add a way to identify the Xray parent (if any) of a given function. v2

We should document that the return value of XrayAwareCalleeGlobal may not be same-compartment with the argument, just to make it clear.

r=me

Comment 6

[Bobby Holley (:bholley)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b5ce69740729

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b5ce69740729