976971 - enable textperf logging for optimized builds

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[John Daggett (:jtd)]

When checking in the textperf logging code, I neglected to carefully test optimized builds.  The logic in nsPresContext::xxx relies on PR logging macros being enabled but FORCE_PR_LOGGING isn't enabled in that file so the PR_LOG_TEST macro evaluates to (0) in non-debug builds:

  // if text perf logging enabled, init stats struct
  PRLogModuleInfo *log = gfxPlatform::GetLog(eGfxLog_textperf);
  if (log && PR_LOG_TEST(log, PR_LOG_WARNING)) {
    mTextPerf = new gfxTextPerfMetrics();
  }

Rather than force logging in this place (no logging is done, the construction of the textperf object is simply conditionalized on logging being enabled), I just need to test the log level directly and avoid the macro.

Comment 1

[John Daggett (:jtd)]

Attachment: patch, test log level directly in nsPresContext::nsPresContext

This allows textperf logging to work correctly in optimized builds (it's use is disabled for release builds within gfx code).

Comment 2

[John Daggett (:jtd)]

Pushed to inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e126867f926

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8e126867f926