Closed
Bug 977030
Opened 12 years ago
Closed 12 years ago
Remove the useless buglist_joined variable in buglist.cgi
Categories
(Bugzilla :: Query/Bug List, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 5.0
People
(Reporter: LpSolit, Assigned: selsky)
References
Details
(Whiteboard: [Good Intro Bug])
Attachments
(1 file)
|
1.05 KB,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
list/list.html.tmpl already does
[% id = buglist.join(",") %]
and later we use
value="[% buglist_joined FILTER html %]"
where buglist_joined comes from buglist.cgi:
$vars->{'buglist_joined'} = join(',', @bugidlist);
buglist_joined is useless, and we should reuse "id".
|
Reporter | |
Comment 1•12 years ago
|
||
This useless variable was added in Bugzilla 2.20, see bug 250410.
Depends on: 250410
|
Assignee | |
Comment 2•12 years ago
|
||
Assignee: query-and-buglist → selsky
Status: NEW → ASSIGNED
Attachment #8384180 -
Flags: review?(dkl)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 8384180 [details] [diff] [review]
Remove unneeded variable
Review of attachment 8384180 [details] [diff] [review]:
-----------------------------------------------------------------
r=dkl
Attachment #8384180 -
Flags: review?(dkl) → review+
|
|
||
Updated•12 years ago
|
Flags: approval?
Target Milestone: --- → Bugzilla 5.0
|
||
Updated•12 years ago
|
Flags: approval? → approval+
|
|
||
Comment 4•12 years ago
|
||
Thanks for the patch!
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bugzilla/trunk
modified buglist.cgi
modified template/en/default/list/list.html.tmpl
Committed revision 8942.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•