977054 - [Dialer] Visual discrepancies: Conference call participants list

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Noemí Freire (:noemi)]

Remove the visual gap between the UX proposal and the current implementation for the following scenario:
scenario a- Conference call participant list
1. Ellipsis issue (see Bug 974320)
2. Incorrect wording in the header "Group call (2) instead of Conference (2):"

Comment 1

[Noemí Freire (:noemi)]

Attachment: a- Conference call participants list

Comment 2

[Germán Toro del Valle (:gtorodelvalle)]

Paco will work on this bug based on the current status of the VR patch ;-)

Comment 3

[Paco Rampas [:paco]]

Attachment: conference.png

Comment 4

[Paco Rampas [:paco]]

Attachment: patch in github

Comment 5

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_conference_number_participant_list.png

I do not think Vicky is going to be fine with this screenshot :p Remember to get screenshots of the affected pages and ask for ui-review form Vicky ;-) Thanks!

Comment 6

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_conference_contact_participant_list.png

I also see something weird regarding the placement of the icon and the 2 lines of text, but maybe it's me :p Definitely Vicky should tell us if it's right or not :-) Please, ask her for ui-review ;-)

Comment 7

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: calllog_number_long_press_menu_overlay.png

Although I have not tested it in master, I think your patch is affecting the overlays shown in other places. For example, in the Call Log if I long press on an entry I see this :-O I don't know if we are grouping the menu entries at the top now.

Comment 8

[Germán Toro del Valle (:gtorodelvalle)]

Comment on attachment 8425313 [details] [review]
patch in github

:-(

Comment 9

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8425310 [details]
conference.png

Please make the divider line for the list a single line (no shadow)and put the elements on the middle.

Comment 10

[Paco Rampas [:paco]]

Attachment: dual-sim-contact.png

Comment 11

[Paco Rampas [:paco]]

Attachment: conference.png

Comment 12

[Anthony Ricaud (:rik)]

Comment on attachment 8425313 [details] [review]
patch in github

If we need style updates like the no shadow, they should be done in the value selector building block, not in callscreen only. I think the vertical alignment of the inner element should also be a mode that the value selector building block provides. Callscreen should only add a class to the form to ask the building to align the elements to the top.

Using !important is forbidden, unless we have a very strong case to include it.

For numbers with no contact associated, the alignment is also weird, like Germán said in comment 5.

I think this patch should focus on just fixing the Conference title and the ellipsis issue. Other visual adjustments should go in another bug and probably two (one for building block, one for callscreen).

Comment 13

[Paco Rampas [:paco]]

Attachment: conference-participants-ellipsis.png

Comment 14

[Paco Rampas [:paco]]

Attachment: conference-participants.png

Comment 15

[Paco Rampas [:paco]]

Attachment: conference-participants-ellipsis.png

Comment 16

[Paco Rampas [:paco]]

Attachment: conference-participants.png

Comment 17

[Paco Rampas [:paco]]

> I think this patch should focus on just fixing the Conference title and the
> ellipsis issue.
You are right. I uploaded the patch that it fix the ellipsis issue. Could you see it?

> Other visual adjustments should go in another bug and
> probably two (one for building block, one for callscreen).
Also, Arnau has created the bug: 1017465 for making a new selector menu for some cases like this. Therefore, we should create a new patch for applying the new "object menu" in this place.

Comment 18

[Anthony Ricaud (:rik)]

This is not passing the linter tests: https://travis-ci.org/mozilla-b2g/gaia/jobs/26916149

Comment 19

[Doug Sherk (:drs) (inactive)]

I'll fix and land this.

Comment 20

[Doug Sherk (:drs) (inactive)]

https://github.com/mozilla-b2g/gaia/commit/6e7a17b0c93f90ad7cc25db957f948472ab436dc

Comment 21

[Doug Sherk (:drs) (inactive)]

This hasn't been uplifted to 2.0, so it's not fixed for it. I'm not sure what the policy is for feature-b2g:2.0+. Should I uplift it? Or is there more process?

Comment 22

[Maria Angeles Oteo (:oteo)]

Umm, the branch was already created but not sure if it will be merged with master during the day or was already forked...let's wait until Release team comunicates the 2.0 branching to confirm if the patch is included or not.

Comment 23

[Doug Sherk (:drs) (inactive)]

This made it into the 2.0 branch.

Comment 24

[Loli (:lolimartinezcr)]

Tested and working
Hamachi 2.0
Gecko-4604a83
Gaia-af2d019