Closed Bug 977077 Opened 10 years ago Closed 10 years ago

[Cost Control] Check for the number of SIM cards beforehand in order not to waste time in single SIM devices

Categories

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Cost Control
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.0 fixed)

Status:
RESOLVED FIXED
Milestone:
2.0 S3 (6june)
Tracking Flags:
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: mai, Assigned: mai)

References

Details

Attachments

(1 file)

patch v1.0
46 bytes, text/x-github-pull-request
salva
: review+
Details | Review 
Now, the application only works with one icc (the data Icc). 
This module is needed to allow the CC application works with all features on a DSDS scenario (actually only dsds data usage support is covered).
Assignee: nobody → mri
Blocks: 959246
Attached file patch v1.0 — 
Salva, could you review this patch?
Regards
Attachment #8382186 - Flags: review?(salva)
Comment on attachment 8382186 [details] [review]
patch v1.0

Despite I totally agree with this change. Let's land the manager with its tests first and then, in a follow up, we land the adaptation of the current CC. Remove the adaptation part and ask for my review again.

Thank you.
Attachment #8382186 - Flags: review?(salva)
Comment on attachment 8382186 [details] [review]
patch v1.0

Updated the PR, now, the patch only has the new module and its test.
Regards
Attachment #8382186 - Flags: review?(salva)
Comment on attachment 8382186 [details] [review]
patch v1.0

Attend the changes we agreed to improve the public API for this useful module and ask for my review again. Anyway, good work!
Attachment #8382186 - Flags: review?(salva)
Summary: [Cost Control] New module Sim Manager → [Cost Control] Check for the number of SIM cards beforehand in order not to lose time in single SIM devices
Summary: [Cost Control] Check for the number of SIM cards beforehand in order not to lose time in single SIM devices → [Cost Control] Check for the number of SIM cards beforehand in order not to waste time in single SIM devices
Comment on attachment 8382186 [details] [review]
patch v1.0

update the PR with your comments, do you mind give me your feedback again?
Regards
Attachment #8382186 - Flags: feedback?(salva)
Comment on attachment 8382186 [details] [review]
patch v1.0

It's going well but please, address the changes on GitHub and ask for feedback again.
Attachment #8382186 - Flags: feedback?(salva)
Comment on attachment 8382186 [details] [review]
patch v1.0

Updated the PR with your comments. Could you give me your feedback?
Regards
Attachment #8382186 - Flags: feedback?(salva)
Comment on attachment 8382186 [details] [review]
patch v1.0

Looks promising. Go on!
Thank you.
Attachment #8382186 - Flags: feedback?(salva) → feedback+
OS: Windows 7 → Gonk (Firefox OS)
Hardware: x86_64 → ARM
Comment on attachment 8382186 [details] [review]
patch v1.0

Updated the PR. 
Replacing methods of the Common module by the methods of the SimManager module.

Salva, please, would you give me your feedback?
Regards
Attachment #8382186 - Flags: feedback+ → feedback?(salva)
Depends on: 968087
Comment on attachment 8382186 [details] [review]
patch v1.0

Salva, would you mind reviewing the patch?
Regards
Attachment #8382186 - Flags: feedback?(salva) → review?(salva)
Comment on attachment 8382186 [details] [review]
patch v1.0

See the comments on GitHub but all seems ok.

Nevertheless, next time let's try to land several medium patches instead of a gigantic one.

Thank you.
Attachment #8382186 - Flags: review?(salva) → review+
Master: fa77df3bd7e910085141d4ce16439dc8f5638ed2
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
status-b2g-v2.0: --- → fixed
Target Milestone: --- → 2.0 S3 (6june)
Depends on: 1020977
Depends on: 1022641
Depends on: 1021439
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: